Worker: Remove ThreadedMessagingProxyBase::WorkerThreadCreated() for cleanup

ThreadedMessagingProxyBase::WorkerThreadCreated() is provided as a virtual
function for DedicatedWorkerMessagingProxy to post queued tasks to the worker
after thread creation. However, DedicatedWorkerMessagingProxy itself initiates
the thread creation in StartWorkerGlobalScope() and can know when it's
available, so such the virtual function is not necessary.

For cleanup, this CL removes WorkerThreadCreated() and inlines posting the
queued tasks in StartWorkerGlobalScope().

Bug: 680046
Change-Id: I5248c78d381e0820461e167249ce89bac93e44a5
Reviewed-on: https://chromium-review.googlesource.com/823052
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523719}

third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp

@@ -94,6 +94,20 @@ void DedicatedWorkerMessagingProxy::StartWorkerGlobalScope(
   InitializeWorkerThread(std::move(global_scope_creation_params),
                          CreateBackingThreadStartupData(ToIsolate(document)),
                          script_url, stack_id, source_code);
+
+  // Post all queued tasks to the worker.
+  for (auto& queued_task : queued_early_tasks_) {
+    WTF::CrossThreadClosure task = CrossThreadBind(
+        &DedicatedWorkerObjectProxy::ProcessMessageFromWorkerObject,
+        CrossThreadUnretained(&WorkerObjectProxy()),
+        WTF::Passed(std::move(queued_task.message)),
+        WTF::Passed(std::move(queued_task.channels)),
+        CrossThreadUnretained(GetWorkerThread()), queued_task.stack_id);
+    GetWorkerThread()
+        ->GetTaskRunner(TaskType::kPostedMessage)
+        ->PostTask(BLINK_FROM_HERE, std::move(task));
+  }
+  queued_early_tasks_.clear();
 }
 
 void DedicatedWorkerMessagingProxy::PostMessageToWorkerGlobalScope(
@@ -122,24 +136,6 @@ void DedicatedWorkerMessagingProxy::PostMessageToWorkerGlobalScope(
   }
 }
 
-void DedicatedWorkerMessagingProxy::WorkerThreadCreated() {
-  DCHECK(IsParentContextThread());
-  ThreadedMessagingProxyBase::WorkerThreadCreated();
-
-  for (auto& queued_task : queued_early_tasks_) {
-    WTF::CrossThreadClosure task = CrossThreadBind(
-        &DedicatedWorkerObjectProxy::ProcessMessageFromWorkerObject,
-        CrossThreadUnretained(&WorkerObjectProxy()),
-        std::move(queued_task.message),
-        WTF::Passed(std::move(queued_task.channels)),
-        CrossThreadUnretained(GetWorkerThread()), queued_task.stack_id);
-    GetWorkerThread()
-        ->GetTaskRunner(TaskType::kPostedMessage)
-        ->PostTask(BLINK_FROM_HERE, std::move(task));
-  }
-  queued_early_tasks_.clear();
-}
-
 bool DedicatedWorkerMessagingProxy::HasPendingActivity() const {
   DCHECK(IsParentContextThread());
   return !AskedToTerminate();

third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.h

@@ -48,9 +48,6 @@ class CORE_EXPORT DedicatedWorkerMessagingProxy
                                       Vector<MessagePortChannel>,
                                       const v8_inspector::V8StackTraceId&);
 
-  // Implements ThreadedMessagingProxyBase.
-  void WorkerThreadCreated() override;
-
   bool HasPendingActivity() const;
 
   // These methods come from worker context thread via

third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp

@@ -89,7 +89,6 @@ void ThreadedMessagingProxyBase::InitializeWorkerThread(
           GetWorkerInspectorProxy()->ShouldPauseOnWorkerStart(document),
           stack_id),
       GetParentFrameTaskRunners(), source_code);
-  WorkerThreadCreated();
   GetWorkerInspectorProxy()->WorkerThreadCreated(document, GetWorkerThread(),
                                                  script_url);
 }
@@ -117,12 +116,6 @@ void ThreadedMessagingProxyBase::ReportConsoleMessage(
                                                          std::move(location));
 }
 
-void ThreadedMessagingProxyBase::WorkerThreadCreated() {
-  DCHECK(IsParentContextThread());
-  DCHECK(!asked_to_terminate_);
-  DCHECK(worker_thread_);
-}
-
 void ThreadedMessagingProxyBase::ParentObjectDestroyed() {
   DCHECK(IsParentContextThread());
   if (worker_thread_) {

third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h

@@ -78,7 +78,6 @@ class CORE_EXPORT ThreadedMessagingProxyBase
       const KURL& script_url,
       const v8_inspector::V8StackTraceId&,
       const String& source_code = String());
-  virtual void WorkerThreadCreated();
 
   ThreadableLoadingContext* CreateThreadableLoadingContext() const;