Commit 6d270871 authored by Xianzhu Wang's avatar Xianzhu Wang Committed by Commit Bot

[PE] Don't call HasSelfPaintingLayerDescendant() from PaintLayer::SetNeedsRepaint()

because we may be during changing the layer tree and
HasSelfPaintingLayerDescendant() may traverse the descendants.

Bug: 830179
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I091c60343d81a4286eb4ebada91bd1f8e3dd6289
Reviewed-on: https://chromium-review.googlesource.com/1002891Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549279}
parent 2e7a0eaa
......@@ -3288,8 +3288,7 @@ void PaintLayer::MarkCompositingContainerChainForNeedsRepaint() {
// this layer's Container(), so in addition to the CompositingContainer()
// chain, we also need to mark NeedsRepaint for Parent().
// TODO(crbug.com/828103): clean up this.
if (layer->Parent() && !layer->IsSelfPaintingLayer() &&
layer->HasSelfPaintingLayerDescendant())
if (layer->Parent() && !layer->IsSelfPaintingLayer())
layer->Parent()->SetNeedsRepaint();
PaintLayer* container = layer->CompositingContainer();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment