Fail if an isolate entry refers to a missing file.

This might have been useful before while trying to get the system running. But now we have swarming running on Linux/Mac/Windows trybots, so it's not so useful. It's also confusing when tests fail on swarming machines because an isolate file referred to a binary that wasn't in the dependencies.

BUG=414808

Review URL: https://codereview.chromium.org/575363002

Cr-Commit-Position: refs/heads/master@{#295514}

build/common.gypi

@@ -591,7 +591,7 @@
       'test_isolation_outdir%': '',
       # True if isolate should fail if the isolate files refer to files
       # that are missing.
-      'test_isolation_fail_on_missing': 0,
+      'test_isolation_fail_on_missing': 1,
 
       'wix_path%': '<(DEPTH)/third_party/wix',
 

chrome/chrome.isolate

@@ -61,11 +61,17 @@
           '<(PRODUCT_DIR)/chrome_elf.dll',
           '<(PRODUCT_DIR)/ffmpegsumo.dll',
           '<(PRODUCT_DIR)/libexif.dll',
-          '<(PRODUCT_DIR)/nacl64<(EXECUTABLE_SUFFIX)',
           '<(PRODUCT_DIR)/osmesa.dll',
         ],
       },
     }],
+    ['OS=="win" and target_arch=="ia32"', {
+      'variables': {
+        'isolate_dependency_tracked': [
+          '<(PRODUCT_DIR)/nacl64.exe',
+        ],
+      },
+    }],
     ['OS=="win" and component=="static_library"', {
       'variables': {
         'isolate_dependency_tracked': [

mojo/mojo_apps_js_unittests.isolate

@@ -30,7 +30,6 @@
     ['OS=="win"', {
       'variables': {
         'isolate_dependency_tracked': [
-          '<(PRODUCT_DIR)/mojo_system.dll',
           '<(PRODUCT_DIR)/mojo_test_support.dll',
         ],
       },

mojo/mojo_js_unittests.isolate

@@ -29,7 +29,6 @@
     ['OS=="win"', {
       'variables': {
         'isolate_dependency_tracked': [
-          '<(PRODUCT_DIR)/mojo_system.dll',
           '<(PRODUCT_DIR)/mojo_test_support.dll',
         ],
       },