Commit 6d453fc2 authored by Suzy Li's avatar Suzy Li Committed by Commit Bot

Revert "Remove unused callback and handler for isUVPAA"

This reverts commit 05e16b52.

Reason for revert: Clank should use the GmsCore implementation of isUVPAA, see crbug.com/1017587

Original change's description:
> Remove unused callback and handler for isUVPAA
>
> This CL aims at removing rest of the code to use gmscore isUVPAA.
>
> This CL is the third of 3 CLs to add isUVPAA implemenration on clank
> and remove the flow to call isUVPAA that gmscore supports.
> First CL:
> https://chromium-review.googlesource.com/c/chromium/src/+/1739973
> Second CL:
> https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1587528
>
> Bug: n/a
> Change-Id: I8f045738e3b3213184e7109bb42f1924ad8c55b0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750406
> Commit-Queue: Suzy Li <suzyli@google.com>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#686483}

TBR=kenrb@chromium.org,suzyli@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1017587
Change-Id: Ieb9e7b9c18a9f36775fdf4b579637a34e55a4959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880127Reviewed-by: default avatarMartin Kreichgauer <martinkr@google.com>
Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
Commit-Queue: Suzy Li <suzyli@google.com>
Cr-Commit-Position: refs/heads/master@{#709258}
parent 0068fa1b
...@@ -40,6 +40,8 @@ public class AuthenticatorImpl extends HandlerResponseCallback implements Authen ...@@ -40,6 +40,8 @@ public class AuthenticatorImpl extends HandlerResponseCallback implements Authen
.Callback2<Integer, MakeCredentialAuthenticatorResponse> mMakeCredentialCallback; .Callback2<Integer, MakeCredentialAuthenticatorResponse> mMakeCredentialCallback;
private org.chromium.mojo.bindings.Callbacks private org.chromium.mojo.bindings.Callbacks
.Callback2<Integer, GetAssertionAuthenticatorResponse> mGetAssertionCallback; .Callback2<Integer, GetAssertionAuthenticatorResponse> mGetAssertionCallback;
private org.chromium.mojo.bindings.Callbacks
.Callback1<Boolean> mIsUserVerifyingPlatformAuthenticatorAvailableCallback;
/** /**
* Builds the Authenticator service implementation. * Builds the Authenticator service implementation.
......
...@@ -50,4 +50,7 @@ public class Fido2ApiHandler { ...@@ -50,4 +50,7 @@ public class Fido2ApiHandler {
protected void getAssertion(PublicKeyCredentialRequestOptions options, protected void getAssertion(PublicKeyCredentialRequestOptions options,
RenderFrameHost frameHost, HandlerResponseCallback callback) {} RenderFrameHost frameHost, HandlerResponseCallback callback) {}
protected void isUserVerifyingPlatformAuthenticatorAvailable(
RenderFrameHost frameHost, HandlerResponseCallback callback) {}
} }
...@@ -23,6 +23,12 @@ public class HandlerResponseCallback { ...@@ -23,6 +23,12 @@ public class HandlerResponseCallback {
*/ */
public void onSignResponse(Integer status, GetAssertionAuthenticatorResponse response){}; public void onSignResponse(Integer status, GetAssertionAuthenticatorResponse response){};
/**
* Callback for handling response from a request to call
* isUserVerifyingPlatformAuthenticatorAvailable.
*/
public void onIsUserVerifyingPlatformAuthenticatorAvailableResponse(boolean isUVPAA){};
/** /**
* Callback for handling any errors from either register or sign requests. * Callback for handling any errors from either register or sign requests.
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment