FileSystem API: clang-tidy fixes for tests.

Change-Id: I1a94ca367a960989747bbf611558b1b1efc295a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344655
Auto-Submit: Victor Costan <pwnall@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821064}

storage/browser/file_system/copy_or_move_operation_delegate_unittest.cc

@@ -305,15 +305,15 @@ class CopyOrMoveOperationTestHelper {
       FileSystemURL dir = directories.front();
       directories.pop();
       ASSERT_EQ(base::File::FILE_OK, ReadDirectory(dir, &entries));
-      for (size_t i = 0; i < entries.size(); ++i) {
+      for (const filesystem::mojom::DirectoryEntry& entry : entries) {
         FileSystemURL url = file_system_context_->CreateCrackedFileSystemURL(
             dir.origin(), dir.mount_type(),
-            dir.virtual_path().Append(entries[i].name));
+            dir.virtual_path().Append(entry.name));
         base::FilePath relative;
         root.virtual_path().AppendRelativePath(url.virtual_path(), &relative);
         relative = relative.NormalizePathSeparators();
         ASSERT_TRUE(base::Contains(test_case_map, relative));
-        if (entries[i].type == filesystem::mojom::FsFileType::DIRECTORY) {
+        if (entry.type == filesystem::mojom::FsFileType::DIRECTORY) {
           EXPECT_TRUE(test_case_map[relative]->is_directory);
           directories.push(url);
         } else {

storage/browser/file_system/file_system_operation_impl_unittest.cc

@@ -979,11 +979,12 @@ TEST_F(FileSystemOperationImplTest, TestReadDirSuccess) {
   EXPECT_EQ(base::File::FILE_OK, ReadDirectory(parent_dir));
   EXPECT_EQ(2u, entries().size());
 
-  for (size_t i = 0; i < entries().size(); ++i) {
-    if (entries()[i].type == filesystem::mojom::FsFileType::DIRECTORY)
-      EXPECT_EQ(FILE_PATH_LITERAL("child_dir"), entries()[i].name.value());
-    else
-      EXPECT_EQ(FILE_PATH_LITERAL("child_file"), entries()[i].name.value());
+  for (const filesystem::mojom::DirectoryEntry& entry : entries()) {
+    if (entry.type == filesystem::mojom::FsFileType::DIRECTORY) {
+      EXPECT_EQ(FILE_PATH_LITERAL("child_dir"), entry.name.value());
+    } else {
+      EXPECT_EQ(FILE_PATH_LITERAL("child_file"), entry.name.value());
+    }
   }
   EXPECT_EQ(1, quota_manager_proxy()->notify_storage_accessed_count());
   EXPECT_TRUE(change_observer()->HasNoChange());