Commit 6d78ae46 authored by atanasova's avatar atanasova Committed by Commit bot

Update FilteringResult UMA to include whitelist information.

Add new histogram value for hen a navigation is allowed due to it being
part of a whitelist.

BUG=595640

Review URL: https://codereview.chromium.org/1810923002

Cr-Commit-Position: refs/heads/master@{#381723}
parent 834f4f74
...@@ -30,14 +30,15 @@ enum { ...@@ -30,14 +30,15 @@ enum {
FILTERING_BEHAVIOR_BLOCK_SAFESITES, FILTERING_BEHAVIOR_BLOCK_SAFESITES,
FILTERING_BEHAVIOR_BLOCK_MANUAL, FILTERING_BEHAVIOR_BLOCK_MANUAL,
FILTERING_BEHAVIOR_BLOCK_DEFAULT, FILTERING_BEHAVIOR_BLOCK_DEFAULT,
FILTERING_BEHAVIOR_MAX = FILTERING_BEHAVIOR_BLOCK_DEFAULT FILTERING_BEHAVIOR_ALLOW_WHITELIST,
FILTERING_BEHAVIOR_MAX = FILTERING_BEHAVIOR_ALLOW_WHITELIST
}; };
const int kHistogramFilteringBehaviorSpacing = 100; const int kHistogramFilteringBehaviorSpacing = 100;
const int kHistogramPageTransitionMaxKnownValue = const int kHistogramPageTransitionMaxKnownValue =
static_cast<int>(ui::PAGE_TRANSITION_KEYWORD_GENERATED); static_cast<int>(ui::PAGE_TRANSITION_KEYWORD_GENERATED);
const int kHistogramPageTransitionFallbackValue = const int kHistogramPageTransitionFallbackValue =
kHistogramFilteringBehaviorSpacing - 1; kHistogramFilteringBehaviorSpacing - 1;
const int kHistogramMax = 700; const int kHistogramMax = 800;
static_assert(kHistogramPageTransitionMaxKnownValue < static_assert(kHistogramPageTransitionMaxKnownValue <
kHistogramPageTransitionFallbackValue, kHistogramPageTransitionFallbackValue,
...@@ -53,6 +54,8 @@ int GetHistogramValueForFilteringBehavior( ...@@ -53,6 +54,8 @@ int GetHistogramValueForFilteringBehavior(
switch (behavior) { switch (behavior) {
case SupervisedUserURLFilter::ALLOW: case SupervisedUserURLFilter::ALLOW:
case SupervisedUserURLFilter::WARN: case SupervisedUserURLFilter::WARN:
if (reason == SupervisedUserURLFilter::WHITELIST)
return FILTERING_BEHAVIOR_ALLOW_WHITELIST;
return uncertain ? FILTERING_BEHAVIOR_ALLOW_UNCERTAIN return uncertain ? FILTERING_BEHAVIOR_ALLOW_UNCERTAIN
: FILTERING_BEHAVIOR_ALLOW; : FILTERING_BEHAVIOR_ALLOW;
case SupervisedUserURLFilter::BLOCK: case SupervisedUserURLFilter::BLOCK:
......
...@@ -82415,6 +82415,42 @@ To add a new entry, add it with any value and run test to compute valid value. ...@@ -82415,6 +82415,42 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="699" label="OTHER_BLOCKED_DEFAULT"> <int value="699" label="OTHER_BLOCKED_DEFAULT">
Other navigation; Blocked by global settings Other navigation; Blocked by global settings
</int> </int>
<int value="700" label="LINK_ALLOWED_WHITELIST">
Link; Allowed by whitelist
</int>
<int value="701" label="TYPED_ALLOWED_WHITELIST">
Typed URL; Allowed by whitelist
</int>
<int value="702" label="AUTO_BOOKMARK_ALLOWED_WHITELIST">
Bookmark; Allowed by whitelist
</int>
<int value="703" label="AUTO_SUBFRAME_ALLOWED_WHITELIST">
Subframe navigation; Allowed by whitelist
</int>
<int value="704" label="MANUAL_SUBFRAME_ALLOWED_WHITELIST">
Manual subframe navigation; Allowed by whitelist
</int>
<int value="705" label="GENERATED_ALLOWED_WHITELIST">
Generated from Omnibox; Allowed by whitelist
</int>
<int value="706" label="AUTO_TOPLEVEL_ALLOWED_WHITELIST">
Automatic toplevel navigation; Allowed by whitelist
</int>
<int value="707" label="FORM_SUBMIT_ALLOWED_WHITELIST">
Form submission; Allowed by whitelist
</int>
<int value="708" label="RELOAD_ALLOWED_WHITELIST">
Reload; Allowed by whitelist
</int>
<int value="709" label="KEYWORD_ALLOWED_WHITELIST">
Omnibox keyword; Allowed by whitelist
</int>
<int value="710" label="KEYWORD_GENERATED_ALLOWED_WHITELIST">
URL generated from Omnibox keyword; Allowed by whitelist
</int>
<int value="799" label="OTHER_ALLOWED_WHITELIST">
Other navigation; Allowed by whitelist
</int>
</enum> </enum>
<enum name="SuspendAttempt" type="int"> <enum name="SuspendAttempt" type="int">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment