Commit 6d7e29f5 authored by thakis@chromium.org's avatar thakis@chromium.org

Try to fix a crash in the new sync machine code

This adds back the fallback code that was deleted after the 10.6
migration in https://chromiumcodereview.appspot.com/10807052,
it's necessary again.

BUG=140256,138570

Review URL: https://chromiumcodereview.appspot.com/10824151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149715 0039d316-1c4b-4281-b951-d872f2087c98
parent 335d4ea5
......@@ -5,8 +5,10 @@
#include "sync/util/get_session_name_mac.h"
#import <SystemConfiguration/SCDynamicStoreCopySpecific.h>
#include <sys/sysctl.h>
#include "base/mac/scoped_cftyperef.h"
#include "base/string_util.h"
#include "base/sys_string_conversions.h"
namespace syncer {
......@@ -16,10 +18,31 @@ std::string GetHardwareModelName() {
// Do not use NSHost currentHost, as it's very slow. http://crbug.com/138570
SCDynamicStoreContext context = { 0, NULL, NULL, NULL };
base::mac::ScopedCFTypeRef<SCDynamicStoreRef> store(
SCDynamicStoreCreate(kCFAllocatorDefault, CFSTR("policy_subsystem"),
SCDynamicStoreCreate(kCFAllocatorDefault, CFSTR("chrome_sync"),
NULL, &context));
CFStringRef machine_name = SCDynamicStoreCopyLocalHostName(store.get());
return base::SysCFStringRefToUTF8(machine_name);
base::mac::ScopedCFTypeRef<CFStringRef> machine_name(
SCDynamicStoreCopyLocalHostName(store.get()));
if (machine_name.get())
return base::SysCFStringRefToUTF8(machine_name.get());
// Fall back to get computer name.
base::mac::ScopedCFTypeRef<CFStringRef> computer_name(
SCDynamicStoreCopyComputerName(store.get(), NULL));
if (computer_name.get())
return base::SysCFStringRefToUTF8(computer_name.get());
// If all else fails, return to using a slightly nicer version of the
// hardware model.
char modelBuffer[256];
size_t length = sizeof(modelBuffer);
if (!sysctlbyname("hw.model", modelBuffer, &length, NULL, 0)) {
for (size_t i = 0; i < length; i++) {
if (IsAsciiDigit(modelBuffer[i]))
return std::string(modelBuffer, 0, i);
}
return std::string(modelBuffer, 0, length);
}
return "Unknown";
}
} // namespace internal
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment