Commit 6d93ae7e authored by philipj@opera.com's avatar philipj@opera.com

Remove fallback matching ::cue* pseudo-element selectors

Because there is a "cue" entry in both pseudoTypeWithoutArgumentsMap and
pseudoTypeWithArgumentsMap, this path is never taken (verified with
ASSERT(0)) when running LayoutTests/media/.

It is taken for something like ::cuefoo, but that makes no sense.

This was initially the only code path:
http://trac.webkit.org/changeset/136991

Later commits made it obsolete:
http://trac.webkit.org/changeset/137955
https://src.chromium.org/viewvc/blink?revision=155834&view=revision

This was the last usage of PseudoUserAgentCustomElement, so remove that
too, together with its use counter:
https://src.chromium.org/viewvc/blink?revision=155928&view=revision
https://www.chromestatus.com/metrics/feature/timeline/popularity/103

At the time pseudos starting with "x-" were also
PseudoUserAgentCustomElement, but has since been removed:
https://src.chromium.org/viewvc/blink?revision=170210&view=revision

Review URL: https://codereview.chromium.org/646853007

git-svn-id: svn://svn.chromium.org/blink/trunk@184341 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent d8d43701
......@@ -242,7 +242,6 @@ PseudoId CSSSelector::pseudoId(PseudoType type)
case PseudoRightPage:
case PseudoInRange:
case PseudoOutOfRange:
case PseudoUserAgentCustomElement:
case PseudoWebKitCustomElement:
case PseudoCue:
case PseudoFutureCue:
......@@ -443,8 +442,6 @@ CSSSelector::PseudoType CSSSelector::parsePseudoType(const AtomicString& name, b
if (name.startsWith("-webkit-"))
return PseudoWebKitCustomElement;
if (name.startsWith("cue"))
return PseudoUserAgentCustomElement;
return PseudoUnknown;
}
......@@ -476,7 +473,6 @@ void CSSSelector::extractPseudoType() const
case PseudoScrollbarTrack:
case PseudoScrollbarTrackPiece:
case PseudoSelection:
case PseudoUserAgentCustomElement:
case PseudoWebKitCustomElement:
case PseudoContent:
case PseudoShadow:
......
......@@ -205,7 +205,6 @@ namespace blink {
PseudoFullScreenAncestor,
PseudoInRange,
PseudoOutOfRange,
PseudoUserAgentCustomElement,
PseudoWebKitCustomElement,
PseudoCue,
PseudoFutureCue,
......@@ -405,7 +404,7 @@ inline bool CSSSelector::matchesPseudoElement() const
inline bool CSSSelector::isCustomPseudoElement() const
{
return m_match == PseudoElement && (m_pseudoType == PseudoUserAgentCustomElement || m_pseudoType == PseudoWebKitCustomElement);
return m_match == PseudoElement && m_pseudoType == PseudoWebKitCustomElement;
}
inline bool CSSSelector::isHostPseudoClass() const
......
......@@ -170,7 +170,6 @@ static bool requiresSubtreeInvalidation(const CSSSelector& selector)
case CSSSelector::PseudoFullScreen:
case CSSSelector::PseudoFullScreenDocument:
case CSSSelector::PseudoFullScreenAncestor:
case CSSSelector::PseudoUserAgentCustomElement:
case CSSSelector::PseudoWebKitCustomElement:
case CSSSelector::PseudoCue:
case CSSSelector::PseudoFutureCue:
......
......@@ -923,9 +923,6 @@ CSSParserSelector* BisonCSSParser::rewriteSpecifiersWithElementName(const Atomic
CSSParserSelector* BisonCSSParser::rewriteSpecifiersWithElementNameForCustomPseudoElement(const QualifiedName& tag, const AtomicString& elementName, CSSParserSelector* specifiers, bool tagIsForNamespaceRule)
{
if (m_context.useCounter() && specifiers->pseudoType() == CSSSelector::PseudoUserAgentCustomElement)
m_context.useCounter()->count(UseCounter::CSSPseudoElementUserAgentCustomPseudo);
CSSParserSelector* lastShadowPseudo = specifiers;
CSSParserSelector* history = specifiers;
while (history->tagHistory()) {
......
......@@ -2372,7 +2372,7 @@ const AtomicString& Element::shadowPseudoId() const
void Element::setShadowPseudoId(const AtomicString& id)
{
ASSERT(CSSSelector::parsePseudoType(id, false) == CSSSelector::PseudoWebKitCustomElement || CSSSelector::parsePseudoType(id, false) == CSSSelector::PseudoUserAgentCustomElement);
ASSERT(CSSSelector::parsePseudoType(id, false) == CSSSelector::PseudoWebKitCustomElement);
setAttribute(pseudoAttr, id);
}
......
......@@ -134,7 +134,6 @@ public:
SubFrameBeforeUnloadFired = 98,
TextReplaceWholeText = 100,
ConsoleMarkTimeline = 102,
CSSPseudoElementUserAgentCustomPseudo = 103,
ElementGetAttributeNode = 107, // Removed from DOM4.
ElementSetAttributeNode = 108, // Removed from DOM4.
ElementRemoveAttributeNode = 109, // Removed from DOM4.
......
......@@ -140,7 +140,6 @@ const char* pseudoTypeToString(CSSSelector::PseudoType pseudoType)
DEFINE_STRING_MAPPING(PseudoFullScreenAncestor)
DEFINE_STRING_MAPPING(PseudoInRange)
DEFINE_STRING_MAPPING(PseudoOutOfRange)
DEFINE_STRING_MAPPING(PseudoUserAgentCustomElement)
DEFINE_STRING_MAPPING(PseudoWebKitCustomElement)
DEFINE_STRING_MAPPING(PseudoCue)
DEFINE_STRING_MAPPING(PseudoFutureCue)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment