[iOS] Disable find in page keyboard shortcuts on native content pages.

Disables keyboard shortcuts for FIP (cmd+F, cmd+G, cmd+shift+G) on NTP
and other pages where FIP is not available.

Bug: 694971
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7f32c55760a2ed976bac085994223afa50c3b976
Reviewed-on: https://chromium-review.googlesource.com/1046829
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556437}

ios/chrome/browser/ui/browser_view_controller.mm

@@ -4115,6 +4115,16 @@ bubblePresenterForFeature:(const base::Feature&)feature
   return _isOffTheRecord;
 }
 
+- (BOOL)isFindInPageAvailable {
+  Tab* tab = [_model currentTab];
+  if (!tab) {
+    return NO;
+  }
+
+  auto* helper = FindTabHelper::FromWebState(tab.webState);
+  return (helper && helper->CurrentPageSupportsFindInPage());
+}
+
 - (NSUInteger)tabsCount {
   return [_model count];
 }

ios/chrome/browser/ui/key_commands_provider.h

@@ -18,6 +18,10 @@
 // Whether the current profile is off-the-record.
 - (BOOL)isOffTheRecord;
 
+// Whether the Find in Page is available on current page. For example it's not
+// supported on NTP and other native content pages.
+- (BOOL)isFindInPageAvailable;
+
 // Returns the current number of tabs.
 - (NSUInteger)tabsCount;
 

ios/chrome/browser/ui/key_commands_provider.mm

@@ -114,6 +114,33 @@ keyCommandsForConsumer:(id<KeyCommandsPlumbing>)consumer
   // List the commands that only appear when there is at least a tab. When they
   // appear, they are in the HUD since they have titles.
   if (hasTabs) {
+    if ([consumer isFindInPageAvailable]) {
+      [keyCommands addObjectsFromArray:@[
+
+        [UIKeyCommand
+            cr_keyCommandWithInput:@"f"
+                     modifierFlags:UIKeyModifierCommand
+                             title:l10n_util::GetNSStringWithFixup(
+                                       IDS_IOS_TOOLS_MENU_FIND_IN_PAGE)
+                            action:^{
+                              [weakDispatcher showFindInPage];
+                            }],
+        [UIKeyCommand cr_keyCommandWithInput:@"g"
+                               modifierFlags:UIKeyModifierCommand
+                                       title:nil
+                                      action:^{
+                                        [weakDispatcher findNextStringInPage];
+                                      }],
+        [UIKeyCommand
+            cr_keyCommandWithInput:@"g"
+                     modifierFlags:UIKeyModifierCommand | UIKeyModifierShift
+                             title:nil
+                            action:^{
+                              [weakDispatcher findPreviousStringInPage];
+                            }]
+      ]];
+    }
+
     [keyCommands addObjectsFromArray:@[
       [UIKeyCommand cr_keyCommandWithInput:@"l"
                              modifierFlags:UIKeyModifierCommand
@@ -137,26 +164,6 @@ keyCommandsForConsumer:(id<KeyCommandsPlumbing>)consumer
                           action:^{
                             [weakDispatcher bookmarkPage];
                           }],
-      [UIKeyCommand cr_keyCommandWithInput:@"f"
-                             modifierFlags:UIKeyModifierCommand
-                                     title:l10n_util::GetNSStringWithFixup(
-                                               IDS_IOS_TOOLS_MENU_FIND_IN_PAGE)
-                                    action:^{
-                                      [weakDispatcher showFindInPage];
-                                    }],
-      [UIKeyCommand cr_keyCommandWithInput:@"g"
-                             modifierFlags:UIKeyModifierCommand
-                                     title:nil
-                                    action:^{
-                                      [weakDispatcher findNextStringInPage];
-                                    }],
-      [UIKeyCommand
-          cr_keyCommandWithInput:@"g"
-                   modifierFlags:UIKeyModifierCommand | UIKeyModifierShift
-                           title:nil
-                          action:^{
-                            [weakDispatcher findPreviousStringInPage];
-                          }],
       [UIKeyCommand cr_keyCommandWithInput:@"r"
                              modifierFlags:UIKeyModifierCommand
                                      title:l10n_util::GetNSStringWithFixup(

ios/chrome/browser/ui/key_commands_provider_unittest.mm

@@ -65,6 +65,7 @@ TEST_F(KeyCommandsProviderTest, MoreKeyboardCommandsWhenTabs) {
 
   // Tabs.
   [[[mockConsumer expect] andReturnUnsignedInteger:1] tabsCount];
+  [[[mockConsumer expect] andReturnBool:YES] isFindInPageAvailable];
   NSUInteger numberOfKeyCommandsWithTabs =
       [[provider keyCommandsForConsumer:mockConsumer
                      baseViewController:nil
@@ -82,6 +83,7 @@ TEST_F(KeyCommandsProviderTest, LessKeyCommandsWhenTabsAndEditingText) {
 
   // Not editing text.
   [[[mockConsumer expect] andReturnUnsignedInteger:1] tabsCount];
+  [[[mockConsumer expect] andReturnBool:YES] isFindInPageAvailable];
   NSUInteger numberOfKeyCommandsWhenNotEditingText =
       [[provider keyCommandsForConsumer:mockConsumer
                      baseViewController:nil
@@ -90,6 +92,7 @@ TEST_F(KeyCommandsProviderTest, LessKeyCommandsWhenTabsAndEditingText) {
 
   // Editing text.
   [[[mockConsumer expect] andReturnUnsignedInteger:1] tabsCount];
+  [[[mockConsumer expect] andReturnBool:YES] isFindInPageAvailable];
   NSUInteger numberOfKeyCommandsWhenEditingText =
       [[provider keyCommandsForConsumer:mockConsumer
                      baseViewController:nil
@@ -100,4 +103,31 @@ TEST_F(KeyCommandsProviderTest, LessKeyCommandsWhenTabsAndEditingText) {
             numberOfKeyCommandsWhenNotEditingText);
 }
 
+TEST_F(KeyCommandsProviderTest, MoreKeyboardCommandsWhenFindInPageAvailable) {
+  KeyCommandsProvider* provider = [[KeyCommandsProvider alloc] init];
+  id mockConsumer =
+      [OCMockObject mockForProtocol:@protocol(KeyCommandsPlumbing)];
+  id<ApplicationCommands, BrowserCommands, OmniboxFocuser> dispatcher = nil;
+
+  // No Find in Page.
+  [[[mockConsumer expect] andReturnUnsignedInteger:1] tabsCount];
+  [[[mockConsumer expect] andReturnBool:NO] isFindInPageAvailable];
+  NSUInteger numberOfKeyCommandsWithoutFIP =
+      [[provider keyCommandsForConsumer:mockConsumer
+                     baseViewController:nil
+                             dispatcher:dispatcher
+                            editingText:NO] count];
+
+  // Tabs.
+  [[[mockConsumer expect] andReturnUnsignedInteger:1] tabsCount];
+  [[[mockConsumer expect] andReturnBool:YES] isFindInPageAvailable];
+  NSUInteger numberOfKeyCommandsWithFIP =
+      [[provider keyCommandsForConsumer:mockConsumer
+                     baseViewController:nil
+                             dispatcher:dispatcher
+                            editingText:NO] count];
+
+  EXPECT_GT(numberOfKeyCommandsWithFIP, numberOfKeyCommandsWithoutFIP);
+}
+
 }  // namespace