Commit 6dbe703a authored by Gauthier Ambard's avatar Gauthier Ambard Committed by Commit Bot

[iOS] Fix BVC contained animation on first run

The first run animation is done with the BVC being shown and the
FirstRunViewController being presented on the same runloop.
On official, this calls the completion handler of the BVC animation
with finished at NO even if it actually completes.

For now this CL fixes it by ignoring the finished value as it is not
taken into account anywhere else (so it is not working).
The long term solution will be to have a better way to present the
first run.

Fixed: 1056697
Change-Id: Iaf30240f4da98cf9d5856d34b6be174b371f1ccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089767Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748138}
parent f7a3be98
......@@ -224,10 +224,10 @@ const CGFloat kReducedMotionDuration = 0.25;
tab.layer.cornerRadius = tabFinalCornerRadius;
}
completion:^(BOOL finished) {
// When presenting the FirstRun ViewController, this can be called with
// |finished| to NO on official builds. For now, the animation not
// finishing isn't handled anywhere.
tab.clipsToBounds = oldClipsToBounds;
if (!finished && beingPresented) {
[tab removeFromSuperview];
}
if (completion)
completion();
}];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment