Commit 6dc3ae61 authored by Matt Menke's avatar Matt Menke Committed by Commit Bot

Disable a pair of NetworkContextConfigurationBrowserTests.

They are flaky on "non_single_process_mash_browser_tests", likely due
to https://chromium-review.googlesource.com/c/chromium/src/+/1443733.

These look like races with network configuration changes, so are not
real bugs.

NOTRY=true
TBR=asanka@chromium.org

Bug: 928685
Change-Id: I0a6ff4df635b26af56e1c8fd60ad2bc4c1525372
Reviewed-on: https://chromium-review.googlesource.com/c/1454124Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629137}
parent 676d7bc0
...@@ -1117,7 +1117,8 @@ IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationBrowserTest, Hsts) { ...@@ -1117,7 +1117,8 @@ IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationBrowserTest, Hsts) {
// Check that the SSLConfig is hooked up. PRE_SSLConfig checks that changing // Check that the SSLConfig is hooked up. PRE_SSLConfig checks that changing
// local_state() after start modifies the SSLConfig, SSLConfig makes sure the // local_state() after start modifies the SSLConfig, SSLConfig makes sure the
// (now modified) initial value of local_state() is respected. // (now modified) initial value of local_state() is respected.
IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationBrowserTest, PRE_SSLConfig) { IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationBrowserTest,
DISABLED_PRE_SSLConfig) {
if (IsRestartStateWithInProcessNetworkService()) if (IsRestartStateWithInProcessNetworkService())
return; return;
// Start a TLS 1.0 server. // Start a TLS 1.0 server.
...@@ -1164,7 +1165,8 @@ IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationBrowserTest, PRE_SSLConfig) { ...@@ -1164,7 +1165,8 @@ IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationBrowserTest, PRE_SSLConfig) {
EXPECT_EQ(net::ERR_SSL_VERSION_OR_CIPHER_MISMATCH, simple_loader->NetError()); EXPECT_EQ(net::ERR_SSL_VERSION_OR_CIPHER_MISMATCH, simple_loader->NetError());
} }
IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationBrowserTest, SSLConfig) { IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationBrowserTest,
DISABLED_SSLConfig) {
if (IsRestartStateWithInProcessNetworkService()) if (IsRestartStateWithInProcessNetworkService())
return; return;
// Start a TLS 1.0 server. // Start a TLS 1.0 server.
...@@ -1191,7 +1193,8 @@ IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationBrowserTest, SSLConfig) { ...@@ -1191,7 +1193,8 @@ IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationBrowserTest, SSLConfig) {
EXPECT_EQ(net::ERR_SSL_VERSION_OR_CIPHER_MISMATCH, simple_loader->NetError()); EXPECT_EQ(net::ERR_SSL_VERSION_OR_CIPHER_MISMATCH, simple_loader->NetError());
} }
IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationBrowserTest, ProxyConfig) { IN_PROC_BROWSER_TEST_P(NetworkContextConfigurationBrowserTest,
DISABLED_ProxyConfig) {
if (IsRestartStateWithInProcessNetworkService()) if (IsRestartStateWithInProcessNetworkService())
return; return;
SetProxyPref(embedded_test_server()->host_port_pair()); SetProxyPref(embedded_test_server()->host_port_pair());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment