Commit 6dd9ad89 authored by Hans Wennborg's avatar Hans Wennborg Committed by Commit Bot

Remove/replace unnecessary includes of logging.h (ash/)

If the file just needs the CHECK/CHECK_OP/NOTREACHED
macros, use the appropriate header for that instead.
Or if logging.h is not needed at all, remove it.

This is both a nice cleanup (logging.h is a big header,
and including it unnecessarily has compile-time costs),
and part of the final step towards making logging.h no
longer include check.h and the others.

Bug: 1031540
Change-Id: Ifdb52bdd094e9775d5ea91b9014152b950ccd08c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254147
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780394}
parent 534456da
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
#include <vector> #include <vector>
#include "ash/app_list/app_list_export.h" #include "ash/app_list/app_list_export.h"
#include "base/logging.h" #include "base/check_op.h"
#include "base/macros.h" #include "base/macros.h"
namespace ash { namespace ash {
......
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
#include "ash/magnifier/magnifier_glass.h" #include "ash/magnifier/magnifier_glass.h"
#include "ash/shell.h" #include "ash/shell.h"
#include "base/logging.h" #include "base/check_op.h"
#include "third_party/skia/include/core/SkDrawLooper.h" #include "third_party/skia/include/core/SkDrawLooper.h"
#include "ui/compositor/layer.h" #include "ui/compositor/layer.h"
#include "ui/compositor/paint_recorder.h" #include "ui/compositor/paint_recorder.h"
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
#include <utility> #include <utility>
#include "base/logging.h" #include "base/check_op.h"
namespace ash { namespace ash {
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ash/public/cpp/ambient/ambient_client.h" #include "ash/public/cpp/ambient/ambient_client.h"
#include "base/logging.h" #include "base/check_op.h"
namespace ash { namespace ash {
......
...@@ -7,7 +7,6 @@ ...@@ -7,7 +7,6 @@
#include "ash/public/cpp/app_list/vector_icons/vector_icons.h" #include "ash/public/cpp/app_list/vector_icons/vector_icons.h"
#include "base/logging.h"
#include "components/vector_icons/cc_macros.h" #include "components/vector_icons/cc_macros.h"
#include "ui/gfx/vector_icon_types.h" #include "ui/gfx/vector_icon_types.h"
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "ash/public/cpp/image_downloader.h" #include "ash/public/cpp/image_downloader.h"
#include "base/logging.h" #include "base/check_op.h"
namespace ash { namespace ash {
namespace { namespace {
......
...@@ -11,7 +11,6 @@ ...@@ -11,7 +11,6 @@
#include "ash/public/cpp/vector_icons/vector_icons.h" #include "ash/public/cpp/vector_icons/vector_icons.h"
#include "base/logging.h"
#include "components/vector_icons/cc_macros.h" #include "components/vector_icons/cc_macros.h"
#include "ui/gfx/vector_icon_types.h" #include "ui/gfx/vector_icon_types.h"
......
...@@ -7,7 +7,6 @@ ...@@ -7,7 +7,6 @@
#include "ash/resources/vector_icons/vector_icons.h" #include "ash/resources/vector_icons/vector_icons.h"
#include "base/logging.h"
#include "components/vector_icons/cc_macros.h" #include "components/vector_icons/cc_macros.h"
#include "ui/gfx/vector_icon_types.h" #include "ui/gfx/vector_icon_types.h"
......
...@@ -12,7 +12,6 @@ ...@@ -12,7 +12,6 @@
#include "ash/public/cpp/shelf_types.h" #include "ash/public/cpp/shelf_types.h"
#include "ash/shell_observer.h" #include "ash/shell_observer.h"
#include "base/logging.h"
#include "base/macros.h" #include "base/macros.h"
#include "ui/aura/window_observer.h" #include "ui/aura/window_observer.h"
......
...@@ -7,7 +7,6 @@ ...@@ -7,7 +7,6 @@
#include "ash/shortcut_viewer/vector_icons/vector_icons.h" #include "ash/shortcut_viewer/vector_icons/vector_icons.h"
#include "base/logging.h"
#include "components/vector_icons/cc_macros.h" #include "components/vector_icons/cc_macros.h"
#include "ui/gfx/vector_icon_types.h" #include "ui/gfx/vector_icon_types.h"
......
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
#include "ash/ash_export.h" #include "ash/ash_export.h"
#include "ash/session/session_observer.h" #include "ash/session/session_observer.h"
#include "base/containers/queue.h" #include "base/containers/queue.h"
#include "base/logging.h"
#include "base/macros.h" #include "base/macros.h"
#include "components/prefs/pref_change_registrar.h" #include "components/prefs/pref_change_registrar.h"
#include "components/user_manager/user_type.h" #include "components/user_manager/user_type.h"
......
...@@ -6,7 +6,6 @@ ...@@ -6,7 +6,6 @@
#define ASH_WM_TEST_ACTIVATION_DELEGATE_H_ #define ASH_WM_TEST_ACTIVATION_DELEGATE_H_
#include "base/compiler_specific.h" #include "base/compiler_specific.h"
#include "base/logging.h"
#include "base/macros.h" #include "base/macros.h"
#include "ui/events/event_handler.h" #include "ui/events/event_handler.h"
#include "ui/wm/public/activation_change_observer.h" #include "ui/wm/public/activation_change_observer.h"
......
...@@ -13,8 +13,8 @@ ...@@ -13,8 +13,8 @@
#include "ash/ash_export.h" #include "ash/ash_export.h"
#include "base/compiler_specific.h" #include "base/compiler_specific.h"
#include "base/logging.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/notreached.h"
#include "ui/gfx/geometry/rect.h" #include "ui/gfx/geometry/rect.h"
namespace ash { namespace ash {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment