Make fileBrowserHandler & fileManagerPrivate files compile on chromeos only.

This is because they are only available/needed on chromeos.

On my local test setup, I see a reduction of 6672 bytes in chrome binary:

gn gen out/Release --args=' use_goma=true is_clang=true \
is_component_build=true proprietary_codecs=true ffmpeg_branding="Chrome" \
safe_browsing_mode=1 enable_google_now=true is_debug=false \
dcheck_always_on=true '

ninja -C out/Release chrome

With this change:
ls -al out/Release/chrome:
-rwxr-x--- 1 lazyboy eng 61439904 Sep 15 16:03 out/Release/chrome
Without this change:
ls -al out/Release/chrome:
-rwxr-x--- 1 lazyboy eng 61446576 Sep 15 16:04 out/Release/chrome

BUG=376319
Test=Expect no visible change.

Review-Url: https://codereview.chromium.org/2344783004
Cr-Commit-Position: refs/heads/master@{#419356}

chrome/renderer/BUILD.gn

@@ -224,10 +224,6 @@ static_library("renderer") {
       "extensions/chrome_v8_extension_handler.h",
       "extensions/extension_localization_peer.cc",
       "extensions/extension_localization_peer.h",
-      "extensions/file_browser_handler_custom_bindings.cc",
-      "extensions/file_browser_handler_custom_bindings.h",
-      "extensions/file_manager_private_custom_bindings.cc",
-      "extensions/file_manager_private_custom_bindings.h",
       "extensions/media_galleries_custom_bindings.cc",
       "extensions/media_galleries_custom_bindings.h",
       "extensions/notifications_native_handler.cc",
@@ -274,9 +270,7 @@ static_library("renderer") {
       "resources/extensions/declarative_content_custom_bindings.js",
       "resources/extensions/enterprise_platform_keys_custom_bindings.js",
       "resources/extensions/feedback_private_custom_bindings.js",
-      "resources/extensions/file_browser_handler_custom_bindings.js",
       "resources/extensions/file_entry_binding_util.js",
-      "resources/extensions/file_manager_private_custom_bindings.js",
       "resources/extensions/file_system_custom_bindings.js",
       "resources/extensions/file_system_provider_custom_bindings.js",
       "resources/extensions/gcm_custom_bindings.js",
@@ -348,6 +342,14 @@ static_library("renderer") {
 
   if (is_chromeos) {
     deps += [ "//chrome/renderer/leak_detector:leak_detector" ]
+    sources += [
+      "extensions/file_browser_handler_custom_bindings.cc",
+      "extensions/file_browser_handler_custom_bindings.h",
+      "extensions/file_manager_private_custom_bindings.cc",
+      "extensions/file_manager_private_custom_bindings.h",
+      "resources/extensions/file_browser_handler_custom_bindings.js",
+      "resources/extensions/file_manager_private_custom_bindings.js",
+    ]
   }
 }
 

chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

@@ -16,8 +16,6 @@
 #include "chrome/grit/renderer_resources.h"
 #include "chrome/renderer/extensions/app_bindings.h"
 #include "chrome/renderer/extensions/automation_internal_custom_bindings.h"
-#include "chrome/renderer/extensions/file_browser_handler_custom_bindings.h"
-#include "chrome/renderer/extensions/file_manager_private_custom_bindings.h"
 #include "chrome/renderer/extensions/media_galleries_custom_bindings.h"
 #include "chrome/renderer/extensions/notifications_native_handler.h"
 #include "chrome/renderer/extensions/page_capture_custom_bindings.h"
@@ -50,6 +48,11 @@
 #include "chrome/renderer/extensions/cast_streaming_native_handler.h"
 #endif
 
+#if defined(OS_CHROMEOS)
+#include "chrome/renderer/extensions/file_browser_handler_custom_bindings.h"
+#include "chrome/renderer/extensions/file_manager_private_custom_bindings.h"
+#endif
+
 using extensions::NativeHandler;
 
 ChromeExtensionsDispatcherDelegate::ChromeExtensionsDispatcherDelegate() {
@@ -100,6 +103,7 @@ void ChromeExtensionsDispatcherDelegate::RegisterNativeHandlers(
       "sync_file_system",
       std::unique_ptr<NativeHandler>(
           new extensions::SyncFileSystemCustomBindings(context)));
+#if defined(OS_CHROMEOS)
   module_system->RegisterNativeHandler(
       "file_browser_handler",
       std::unique_ptr<NativeHandler>(
@@ -108,6 +112,7 @@ void ChromeExtensionsDispatcherDelegate::RegisterNativeHandlers(
       "file_manager_private",
       std::unique_ptr<NativeHandler>(
           new extensions::FileManagerPrivateCustomBindings(context)));
+#endif  // defined(OS_CHROMEOS)
   module_system->RegisterNativeHandler(
       "notifications_private",
       std::unique_ptr<NativeHandler>(
@@ -184,10 +189,12 @@ void ChromeExtensionsDispatcherDelegate::PopulateSourceMap(
                              IDR_ENTERPRISE_PLATFORM_KEYS_TOKEN_JS);
   source_map->RegisterSource("feedbackPrivate",
                              IDR_FEEDBACK_PRIVATE_CUSTOM_BINDINGS_JS);
+#if defined(OS_CHROMEOS)
   source_map->RegisterSource("fileBrowserHandler",
                              IDR_FILE_BROWSER_HANDLER_CUSTOM_BINDINGS_JS);
   source_map->RegisterSource("fileManagerPrivate",
                              IDR_FILE_MANAGER_PRIVATE_CUSTOM_BINDINGS_JS);
+#endif  // defined(OS_CHROMEOS)
   source_map->RegisterSource("fileSystem", IDR_FILE_SYSTEM_CUSTOM_BINDINGS_JS);
   source_map->RegisterSource("fileSystemProvider",
                              IDR_FILE_SYSTEM_PROVIDER_CUSTOM_BINDINGS_JS);

chrome/renderer/resources/renderer_resources.grd

@@ -55,8 +55,10 @@
         <include name="IDR_ENTERPRISE_PLATFORM_KEYS_SUBTLE_CRYPTO_JS" file="extensions\enterprise_platform_keys\subtle_crypto.js" type="BINDATA" />
         <include name="IDR_ENTERPRISE_PLATFORM_KEYS_TOKEN_JS" file="extensions\enterprise_platform_keys\token.js" type="BINDATA" />
         <include name="IDR_FEEDBACK_PRIVATE_CUSTOM_BINDINGS_JS" file="extensions\feedback_private_custom_bindings.js" type="BINDATA" />
-        <include name="IDR_FILE_BROWSER_HANDLER_CUSTOM_BINDINGS_JS" file="extensions\file_browser_handler_custom_bindings.js" type="BINDATA" />
-        <include name="IDR_FILE_MANAGER_PRIVATE_CUSTOM_BINDINGS_JS" file="extensions\file_manager_private_custom_bindings.js" type="BINDATA" />
+        <if expr="chromeos">
+          <include name="IDR_FILE_BROWSER_HANDLER_CUSTOM_BINDINGS_JS" file="extensions\file_browser_handler_custom_bindings.js" type="BINDATA" />
+          <include name="IDR_FILE_MANAGER_PRIVATE_CUSTOM_BINDINGS_JS" file="extensions\file_manager_private_custom_bindings.js" type="BINDATA" />
+        </if>
         <include name="IDR_FILE_ENTRY_BINDING_UTIL_JS" file="extensions\file_entry_binding_util.js" type="BINDATA" />
         <include name="IDR_FILE_SYSTEM_CUSTOM_BINDINGS_JS" file="extensions\file_system_custom_bindings.js" type="BINDATA" />
         <include name="IDR_FILE_SYSTEM_PROVIDER_CUSTOM_BINDINGS_JS" file="extensions\file_system_provider_custom_bindings.js" type="BINDATA" />