Commit 6e5458b0 authored by Andreas Haas's avatar Andreas Haas Committed by Commit Bot

[v8-browsing] Add WebAssembly UMA metrics to v8-browsing

This CL brings WebAssembly UMA metrics to the v8-browsing benchmark in
Telemetry.

R=mythria@chromium.org, clemensb@chromium.org

Bug: chromium:1084929
Change-Id: I28e72378774c3d599da1ad670ba036a3f0ea84e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497164Reviewed-by: default avatarMythri Alle <mythria@chromium.org>
Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820779}
parent 08ce6fc4
......@@ -11,6 +11,19 @@ from telemetry.timeline import chrome_trace_config
from telemetry.web_perf import timeline_based_measurement
import page_sets
V8_BROWSING_BENCHMARK_UMA = [
'V8.WasmCompileModuleMicroSeconds.wasm',
'V8.WasmCompileModuleAsyncMicroSeconds',
'V8.WasmCompileModuleStreamingMicroSeconds',
'V8.WasmFinishModuleStreamingMicroSeconds',
'V8.WasmTierUpModuleMicroSeconds',
'V8.WasmCompileFunctionMicroSeconds.wasm',
'V8.WasmInstantiateModuleMicroSeconds.wasm',
'V8.WasmModuleCodeSizeTopTierMiB',
'V8.WasmCompileFunctionPeakMemoryBytes',
'V8.WasmModuleCodeSizeMiB',
]
def AugmentOptionsForV8BrowsingMetrics(options, enable_runtime_call_stats=True):
categories = [
......@@ -44,14 +57,18 @@ def AugmentOptionsForV8BrowsingMetrics(options, enable_runtime_call_stats=True):
options.config.chrome_trace_config.SetTraceBufferSizeInKb(400 * 1024)
options.config.chrome_trace_config.EnableUMAHistograms(
*V8_BROWSING_BENCHMARK_UMA)
metrics = [
'blinkGcMetric',
'consoleErrorMetric',
'expectedQueueingTimeMetric',
'gcMetric',
'memoryMetric',
'reportedByPageMetric',
'wasmMetric',
'blinkGcMetric',
'consoleErrorMetric',
'expectedQueueingTimeMetric',
'gcMetric',
'memoryMetric',
'reportedByPageMetric',
'umaMetric',
'wasmMetric',
]
options.ExtendTimelineBasedMetric(metrics)
if enable_runtime_call_stats:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment