Commit 6e60fb4b authored by rbpotter's avatar rbpotter Committed by Chromium LUCI CQ

Print Preview: Remove references to cloud print warnings

These are no longer needed since cloud print deprecation is already
ocurring on the server side. Handle only privet related deprecation
flag in Print Preview.

Bug: 1144931
Change-Id: I6ff77f87fda23d33e25f49d6310e41757a3be530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618682
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: default avatarDaniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843436}
parent f7ca9499
......@@ -105,9 +105,6 @@ Polymer({
// Check for the Docs or Save as PDF ids first.
const keyParams = this.selectedValue.split('/');
if (keyParams[0] === Destination.GooglePromotedId.DOCS) {
if (!loadTimeData.getBoolean('cloudPrintDeprecationWarningsSuppressed')) {
return 'print-preview:save-to-drive-not-supported';
}
return 'print-preview:save-to-drive';
}
if (keyParams[0] === Destination.GooglePromotedId.SAVE_AS_PDF) {
......
......@@ -380,10 +380,6 @@ void AddPrintPreviewFlags(content::WebUIDataSource* source, Profile* profile) {
source->AddBoolean("isEnterpriseManaged", webui::IsEnterpriseManaged());
bool cloud_print_deprecation_warnings_suppressed = true;
source->AddBoolean("cloudPrintDeprecationWarningsSuppressed",
cloud_print_deprecation_warnings_suppressed);
#if BUILDFLAG(ENABLE_SERVICE_DISCOVERY)
source->AddBoolean(
"forceEnablePrivetPrinting",
......
......@@ -205,23 +205,11 @@ suite(destination_select_test.suiteName, function() {
}
test(assert(destination_select_test.TestNames.UpdateStatus), function() {
loadTimeData.overrideValues(
{cloudPrintDeprecationWarningsSuppressed: true});
// Repopulate |recentDestinationList| to have
// |cloudPrintDeprecationWarningsSuppressed| take effect during creation of
// new Destinations.
populateRecentDestinationList();
return testUpdateStatus();
});
test(assert(destination_select_test.TestNames.ChangeIcon), function() {
loadTimeData.overrideValues(
{cloudPrintDeprecationWarningsSuppressed: true});
// Repopulate |recentDestinationList| to have
// |cloudPrintDeprecationWarningsSuppressed| take effect during creation of
// new Destinations.
populateRecentDestinationList();
destinationSelect.recentDestinationList = recentDestinationList;
......
......@@ -551,12 +551,6 @@ suite(destination_select_test_cros.suiteName, function() {
}
test(assert(destination_select_test_cros.TestNames.UpdateStatus), function() {
loadTimeData.overrideValues(
{cloudPrintDeprecationWarningsSuppressed: true});
// Repopulate |recentDestinationList| to have
// |cloudPrintDeprecationWarningsSuppressed| take effect during creation of
// new Destinations.
populateRecentDestinationList();
destinationSelect.recentDestinationList = recentDestinationList;
......@@ -566,12 +560,6 @@ suite(destination_select_test_cros.suiteName, function() {
});
test(assert(destination_select_test_cros.TestNames.ChangeIcon), function() {
loadTimeData.overrideValues(
{cloudPrintDeprecationWarningsSuppressed: true});
// Repopulate |recentDestinationList| to have
// |cloudPrintDeprecationWarningsSuppressed| take effect during creation of
// new Destinations.
populateRecentDestinationList();
destinationSelect.recentDestinationList = recentDestinationList;
......
......@@ -113,8 +113,6 @@ suite(invalid_settings_browsertest.suiteName, function() {
* @param {!Array<!Destination>} printers
*/
function setupInvalidCertificateTest(printers) {
loadTimeData.overrideValues(
{cloudPrintDeprecationWarningsSuppressed: true});
initialSettings.printerName = '';
initialSettings.serializedAppStateStr = JSON.stringify({
version: 2,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment