Commit 6e721d8e authored by George Burgess IV's avatar George Burgess IV Committed by Commit Bot

fix instances of bugprone-argument-comment

This new clang-tidy check complains when param names /*in_comments=*/
don't match up with the actual parameter name they're being passed to.
Sometimes this is benign, other times, actual bugs are found.

Bug: 1136209
Change-Id: I1fd87d09c51889669dc1fe0e6d95508fcc28f643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458890Reviewed-by: default avatarRushan Suleymanov <rushans@google.com>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816261}
parent cd631cd8
...@@ -684,7 +684,7 @@ TEST_F(BookmarkModelTypeProcessorTest, ...@@ -684,7 +684,7 @@ TEST_F(BookmarkModelTypeProcessorTest,
ASSERT_EQ(0u, bookmark_client()->GetTasksCount()); ASSERT_EQ(0u, bookmark_client()->GetTasksCount());
EXPECT_CALL(callback, Run(_)); EXPECT_CALL(callback, Run(_));
processor()->GetLocalChanges(/*max_entities=*/10, callback.Get()); processor()->GetLocalChanges(/*max_entries=*/10, callback.Get());
EXPECT_TRUE(callback_result.empty()); EXPECT_TRUE(callback_result.empty());
EXPECT_TRUE(node->is_favicon_loading()); EXPECT_TRUE(node->is_favicon_loading());
...@@ -692,7 +692,7 @@ TEST_F(BookmarkModelTypeProcessorTest, ...@@ -692,7 +692,7 @@ TEST_F(BookmarkModelTypeProcessorTest,
GURL(kIconUrl)); GURL(kIconUrl));
ASSERT_TRUE(node->is_favicon_loaded()); ASSERT_TRUE(node->is_favicon_loaded());
EXPECT_CALL(callback, Run(_)); EXPECT_CALL(callback, Run(_));
processor()->GetLocalChanges(/*max_entities=*/10, callback.Get()); processor()->GetLocalChanges(/*max_entries=*/10, callback.Get());
EXPECT_FALSE(callback_result.empty()); EXPECT_FALSE(callback_result.empty());
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment