Remove prefs::kReverseAutologinEnabled & DisableOneClickSignIn

This patch means removing the preference and functions
that reference it.
Because preference is set but never read, that is indeed obsolete.

Bug: 889908
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I22a80bed2387b08480dae9c930bb1d329dd8c45d
Reviewed-on: https://chromium-review.googlesource.com/c/1264343
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599200}

chrome/browser/prefs/browser_prefs.cc

@@ -373,6 +373,9 @@ const char kLastWelcomedOSVersion[] = "browser.last_welcomed_os_version";
 const char kSupervisedUserCreationAllowed[] =
     "profile.managed_user_creation_allowed";
 
+// Deprecated 10/2018
+const char kReverseAutologinEnabled[] = "reverse_autologin.enabled";
+
 // Register prefs used only for migration (clearing or moving to a new key).
 void RegisterProfilePrefsForMigration(
     user_prefs::PrefRegistrySyncable* registry) {
@@ -396,6 +399,8 @@ void RegisterProfilePrefsForMigration(
   registry->RegisterIntegerPref(kOptionsWindowLastTabIndex, 0);
   registry->RegisterStringPref(kTrustedDownloadSources, std::string());
   registry->RegisterBooleanPref(kSupervisedUserCreationAllowed, true);
+
+  registry->RegisterBooleanPref(kReverseAutologinEnabled, true);
 }
 
 }  // namespace
@@ -851,4 +856,7 @@ void MigrateObsoleteProfilePrefs(Profile* profile) {
   profile_prefs->ClearPref(kOptionsWindowLastTabIndex);
   profile_prefs->ClearPref(kTrustedDownloadSources);
   profile_prefs->ClearPref(kSupervisedUserCreationAllowed);
+
+  // Added 10/2018
+  profile_prefs->ClearPref(kReverseAutologinEnabled);
 }

chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

@@ -274,7 +274,6 @@ class InlineLoginUIBrowserTest : public InProcessBrowserTest {
 
   void SetUpSigninManager(const std::string& username);
   void EnableSigninAllowed(bool enable);
-  void EnableOneClick(bool enable);
   void AddEmailToOneClickRejectedList(const std::string& email);
   void AllowSigninCookies(bool enable);
   void SetAllowedUsernamePattern(const std::string& pattern);
@@ -297,11 +296,6 @@ void InlineLoginUIBrowserTest::EnableSigninAllowed(bool enable) {
   pref_service->SetBoolean(prefs::kSigninAllowed, enable);
 }
 
-void InlineLoginUIBrowserTest::EnableOneClick(bool enable) {
-  PrefService* pref_service = browser()->profile()->GetPrefs();
-  pref_service->SetBoolean(prefs::kReverseAutologinEnabled, enable);
-}
-
 void InlineLoginUIBrowserTest::AddEmailToOneClickRejectedList(
     const std::string& email) {
   PrefService* pref_service = browser()->profile()->GetPrefs();
@@ -380,13 +374,10 @@ IN_PROC_BROWSER_TEST_F(InlineLoginUIBrowserTest, CanOfferNoProfile) {
 }
 
 IN_PROC_BROWSER_TEST_F(InlineLoginUIBrowserTest, CanOffer) {
-  EnableOneClick(true);
   EXPECT_TRUE(CanOfferSignin(browser()->profile(),
                              CAN_OFFER_SIGNIN_FOR_ALL_ACCOUNTS, "12345",
                              "user@gmail.com", NULL));
 
-  EnableOneClick(false);
-
   std::string error_message;
 
   EXPECT_TRUE(CanOfferSignin(browser()->profile(),

components/signin/core/browser/signin_manager.cc

@@ -392,10 +392,6 @@ const std::string& SigninManager::GetUsernameForAuthInProgress() const {
   return possibly_invalid_email_;
 }
 
-void SigninManager::DisableOneClickSignIn(PrefService* prefs) {
-  prefs->SetBoolean(prefs::kReverseAutologinEnabled, false);
-}
-
 void SigninManager::MergeSigninCredentialIntoCookieJar() {
   if (account_consistency_ == signin::AccountConsistencyMethod::kMirror)
     return;
@@ -457,8 +453,6 @@ void SigninManager::OnSignedIn() {
   signin_metrics::LogSigninProfile(client_->IsFirstRun(),
                                    client_->GetInstallDate());
 
-  DisableOneClickSignIn(client_->GetPrefs());  // Don't ever offer again.
-
   PostSignedIn();
 }
 

components/signin/core/browser/signin_manager.h

@@ -181,11 +181,6 @@ class SigninManager : public SigninManagerBase,
   // authenticated. Returns an empty string if no auth is in progress.
   const std::string& GetUsernameForAuthInProgress() const;
 
-  // Set the preference to turn off one-click sign-in so that it won't ever
-  // show it again for the user associated with |prefs| (even if the user tries
-  // a new account).
-  static void DisableOneClickSignIn(PrefService* prefs);
-
  protected:
   // The sign out process which is started by SigninClient::PreSignOut()
   virtual void OnSignoutDecisionReached(

components/signin/core/browser/signin_manager_base.cc

@@ -53,7 +53,6 @@ void SigninManagerBase::RegisterProfilePrefs(PrefRegistrySimple* registry) {
   registry->RegisterStringPref(prefs::kGoogleServicesUserAccountId,
                                std::string());
   registry->RegisterBooleanPref(prefs::kAutologinEnabled, true);
-  registry->RegisterBooleanPref(prefs::kReverseAutologinEnabled, true);
   registry->RegisterListPref(prefs::kReverseAutologinRejectedEmailList,
                              std::make_unique<base::ListValue>());
   registry->RegisterBooleanPref(prefs::kSigninAllowed, true);

components/signin/core/browser/signin_pref_names.cc

@@ -77,9 +77,6 @@ const char kGoogleServicesUsername[] = "google.services.username";
 const char kGoogleServicesUsernamePattern[] =
     "google.services.username_pattern";
 
-// Boolean identifying whether reverse auto-logins is enabled.
-const char kReverseAutologinEnabled[] = "reverse_autologin.enabled";
-
 // List to keep track of emails for which the user has rejected one-click
 // sign-in.
 const char kReverseAutologinRejectedEmailList[] =

components/signin/core/browser/signin_pref_names.h

@@ -23,7 +23,6 @@ extern const char kGoogleServicesSigninScopedDeviceId[];
 extern const char kGoogleServicesUserAccountId[];
 extern const char kGoogleServicesUsername[];
 extern const char kGoogleServicesUsernamePattern[];
-extern const char kReverseAutologinEnabled[];
 extern const char kReverseAutologinRejectedEmailList[];
 extern const char kSignedInTime[];
 extern const char kSigninAllowed[];

ios/chrome/browser/prefs/browser_prefs.mm

@@ -62,6 +62,10 @@
 #error "This file requires ARC support."
 #endif
 
+namespace {
+const char kReverseAutologinEnabled[] = "reverse_autologin.enabled";
+}
+
 void RegisterLocalStatePrefs(PrefRegistrySimple* registry) {
   BrowserStateInfoCache::RegisterPrefs(registry);
   flags_ui::PrefServiceFlagsStorage::RegisterPrefs(registry);
@@ -164,6 +168,8 @@ void RegisterBrowserStatePrefs(user_prefs::PrefRegistrySyncable* registry) {
 
   // Register prefs used by Clear Browsing Data UI.
   browsing_data::prefs::RegisterBrowserUserPrefs(registry);
+
+  registry->RegisterBooleanPref(kReverseAutologinEnabled, true);
 }
 
 // This method should be periodically pruned of year+ old migrations.
@@ -183,4 +189,7 @@ void MigrateObsoleteBrowserStatePrefs(PrefService* prefs) {
 
   // Added 8/2018.
   autofill::prefs::MigrateDeprecatedAutofillPrefs(prefs);
+
+  // Added 10/2018.
+  prefs->ClearPref(kReverseAutologinEnabled);
 }