Commit 6e881158 authored by Caleb Rouleau's avatar Caleb Rouleau

[Benchmarking] Fix PRESUBMIT of timing.

This makes it so that even for unofficial builders you are reminded to run
./generate_perf_sharding.py update-timing --filter-only
if your timing data doesn't match with what you are actually running.

Also run ./generate_perf_sharding.py update-timing --filter-only
to fix the pixel 2 aab timing data.

R=hypan@google.com, johnchen@chromium.org

Change-Id: Idcb8600ca81acb5d81b1e614115ace84dec21376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003789Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732625}
parent 45bca49e
[ []
{ \ No newline at end of file
"duration": "31.0",
"name": "rendering.mobile/balls_javascript_canvas"
},
{
"duration": "29.0",
"name": "rendering.mobile/canvas_05000_pixels_per_second"
},
{
"duration": "28.0",
"name": "rendering.mobile/css_value_type_shadow"
},
{
"duration": "29.0",
"name": "rendering.mobile/extra_large_texture_uploads"
},
{
"duration": "31.0",
"name": "rendering.mobile/main_30fps_impl_60fps"
},
{
"duration": "31.0",
"name": "rendering.mobile/motion_mark_canvas_fill_shapes"
},
{
"duration": "37.0",
"name": "rendering.mobile/new_tilings"
},
{
"duration": "28.0",
"name": "rendering.mobile/text_10000_pixels_per_second"
},
{
"duration": "30.0",
"name": "rendering.mobile/transform_transitions_js_block"
},
{
"duration": "29.0",
"name": "rendering.mobile/web_animations_staggered_infinite_iterations"
}
]
\ No newline at end of file
...@@ -422,7 +422,7 @@ def _ValidateShardMaps(args): ...@@ -422,7 +422,7 @@ def _ValidateShardMaps(args):
'`./generate_perf_sharding.py update-timing --filter-only` ' '`./generate_perf_sharding.py update-timing --filter-only` '
'to regenerate it.'.format(cycletimes=_CYCLETIME_CONTRIBUTION)) 'to regenerate it.'.format(cycletimes=_CYCLETIME_CONTRIBUTION))
builders = _GetBuilderPlatforms(builders=None, waterfall='perf') builders = _GetBuilderPlatforms(builders=None, waterfall='all')
for builder in builders: for builder in builders:
output_file = os.path.join( output_file = os.path.join(
tempdir, os.path.basename(builder.timing_file_path)) tempdir, os.path.basename(builder.timing_file_path))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment