Commit 6ea1b0ee authored by chengx's avatar chengx Committed by Commit bot

Revert some jumplist function names

In crrev.com/2811003002, some methods were renamed which they shouldn't.
This CL changes them back.

BUG=40407, 179576

Review-Url: https://codereview.chromium.org/2812983005
Cr-Commit-Position: refs/heads/master@{#464418}
parent bbafd853
...@@ -231,11 +231,10 @@ bool UpdateJumpList(const wchar_t* app_id, ...@@ -231,11 +231,10 @@ bool UpdateJumpList(const wchar_t* app_id,
} }
// Updates the jumplist, once all the data has been fetched. // Updates the jumplist, once all the data has been fetched.
void RunUpdateJumpListUserVisiblePriority( void RunUpdateJumpList(IncognitoModePrefs::Availability incognito_availability,
IncognitoModePrefs::Availability incognito_availability, const std::wstring& app_id,
const std::wstring& app_id, const base::FilePath& icon_dir,
const base::FilePath& icon_dir, base::RefCountedData<JumpListData>* ref_counted_data) {
base::RefCountedData<JumpListData>* ref_counted_data) {
JumpListData* data = &ref_counted_data->data; JumpListData* data = &ref_counted_data->data;
ShellLinkItemList local_most_visited_pages; ShellLinkItemList local_most_visited_pages;
ShellLinkItemList local_recently_closed_pages; ShellLinkItemList local_recently_closed_pages;
...@@ -508,7 +507,7 @@ void JumpList::StartLoadingFavicon() { ...@@ -508,7 +507,7 @@ void JumpList::StartLoadingFavicon() {
if (!waiting_for_icons) { if (!waiting_for_icons) {
// No more favicons are needed by the application JumpList. Schedule a // No more favicons are needed by the application JumpList. Schedule a
// RunUpdateJumpListUserVisiblePriority call. // RunUpdateJumpList call.
PostRunUpdate(); PostRunUpdate();
return; return;
} }
...@@ -534,7 +533,7 @@ void JumpList::OnFaviconDataAvailable( ...@@ -534,7 +533,7 @@ void JumpList::OnFaviconDataAvailable(
JumpListData* data = &jumplist_data_->data; JumpListData* data = &jumplist_data_->data;
base::AutoLock auto_lock(data->list_lock_); base::AutoLock auto_lock(data->list_lock_);
// Attach the received data to the ShellLinkItem object. // Attach the received data to the ShellLinkItem object.
// This data will be decoded by the RunUpdateJumpListUserVisiblePriority // This data will be decoded by the RunUpdateJumpList
// method. // method.
if (!image_result.image.IsEmpty() && !data->icon_urls_.empty() && if (!image_result.image.IsEmpty() && !data->icon_urls_.empty() &&
data->icon_urls_.front().second.get()) { data->icon_urls_.front().second.get()) {
...@@ -596,15 +595,13 @@ void JumpList::DeferredRunUpdate() { ...@@ -596,15 +595,13 @@ void JumpList::DeferredRunUpdate() {
// Post a task to delete the content in JumpListIcons folder and log the // Post a task to delete the content in JumpListIcons folder and log the
// results to UMA. // results to UMA.
update_jumplisticons_task_runner_->PostTask( update_jumplisticons_task_runner_->PostTask(
FROM_HERE, FROM_HERE, base::Bind(&DeleteDirectoryContentAndLogResults, icon_dir_,
base::Bind(&DeleteDirectoryContentAndLogResultsUserVisiblePriority, kFileDeleteLimit));
icon_dir_, kFileDeleteLimit));
// Post a task to update the jumplist used by the shell. // Post a task to update the jumplist used by the shell.
update_jumplisticons_task_runner_->PostTask( update_jumplisticons_task_runner_->PostTask(
FROM_HERE, FROM_HERE, base::Bind(&RunUpdateJumpList, incognito_availability, app_id_,
base::Bind(&RunUpdateJumpListUserVisiblePriority, incognito_availability, icon_dir_, base::RetainedRef(jumplist_data_)));
app_id_, icon_dir_, base::RetainedRef(jumplist_data_)));
// Post a task to delete JumpListIconsOld folder and log the results to UMA. // Post a task to delete JumpListIconsOld folder and log the results to UMA.
base::FilePath icon_dir_old = icon_dir_.DirName().Append( base::FilePath icon_dir_old = icon_dir_.DirName().Append(
......
...@@ -152,7 +152,7 @@ class JumpList : public sessions::TabRestoreServiceObserver, ...@@ -152,7 +152,7 @@ class JumpList : public sessions::TabRestoreServiceObserver,
// Helper for RunUpdate() that determines its parameters. // Helper for RunUpdate() that determines its parameters.
void PostRunUpdate(); void PostRunUpdate();
// Called on a timer to invoke RunUpdateJumpListUserVisiblePriority() after // Called on a timer to invoke RunUpdateJumpList() after
// requests storms have subsided. // requests storms have subsided.
void DeferredRunUpdate(); void DeferredRunUpdate();
......
...@@ -123,9 +123,8 @@ void DeleteDirectoryAndLogResults(const base::FilePath& path, ...@@ -123,9 +123,8 @@ void DeleteDirectoryAndLogResults(const base::FilePath& path,
dir_status, DIRECTORY_STATUS_END); dir_status, DIRECTORY_STATUS_END);
} }
void DeleteDirectoryContentAndLogResultsUserVisiblePriority( void DeleteDirectoryContentAndLogResults(const base::FilePath& path,
const base::FilePath& path, int max_file_deleted) {
int max_file_deleted) {
DirectoryStatus dir_status = NON_EXIST; DirectoryStatus dir_status = NON_EXIST;
// Delete the content in |path|. If |path| doesn't exist, create one. // Delete the content in |path|. If |path| doesn't exist, create one.
......
...@@ -79,8 +79,7 @@ void DeleteDirectoryAndLogResults(const base::FilePath& path, ...@@ -79,8 +79,7 @@ void DeleteDirectoryAndLogResults(const base::FilePath& path,
int max_file_deleted); int max_file_deleted);
// Deletes the content in the directory at |path| and records the result to UMA. // Deletes the content in the directory at |path| and records the result to UMA.
void DeleteDirectoryContentAndLogResultsUserVisiblePriority( void DeleteDirectoryContentAndLogResults(const base::FilePath& path,
const base::FilePath& path, int max_file_deleted);
int max_file_deleted);
#endif // CHROME_BROWSER_WIN_JUMPLIST_FILE_UTIL_H_ #endif // CHROME_BROWSER_WIN_JUMPLIST_FILE_UTIL_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment