Commit 6eba9435 authored by Rouslan Solomakhin's avatar Rouslan Solomakhin Committed by Chromium LUCI CQ

[Autofill] Increase tap target for text fields.

Before this patch, the touch targets of the autofill card and address
editor text fields were 45dp tall, which is smaller than necessary for
accessibility.

This patch adds a minimum height of 48dp to the text fields in the card
and address editors, while the bottom margin is reduced from 8dp to 5dp
to compensate for the 3dp increase in text field height.

After this patch, the touch targets of the autofill card and address
editor text fields are at least 48dp tall.

Bug: 977272
Change-Id: If356cb5cf64f7b912fbdb924dfc35ecef84eef48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580147Reviewed-by: default avatarDominic Battré <battre@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836091}
parent cec028b4
......@@ -42,6 +42,8 @@
<dimen name="pref_autofill_touch_target_padding">15dp</dimen>
<!-- Editor dialog UI -->
<dimen name="editor_dialog_textview_min_height">48dp</dimen>
<dimen name="editor_dialog_textview_margin_bottom">5dp</dimen>
<dimen name="editor_dialog_section_small_spacing">8dp</dimen>
<dimen name="editor_dialog_section_large_spacing">16dp</dimen>
<dimen name="editor_dialog_section_buttons_vertical_padding">10dp</dimen>
......
......@@ -10,7 +10,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/editor_dialog_section_small_spacing"
android:layout_marginBottom="@dimen/editor_dialog_section_small_spacing">
android:layout_marginBottom="@dimen/editor_dialog_textview_margin_bottom">
<com.google.android.material.textfield.TextInputLayout
android:id="@+id/text_input_layout"
......@@ -24,6 +24,7 @@
android:id="@+id/text_view"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:minHeight="@dimen/editor_dialog_textview_min_height"
android:singleLine="true"
android:imeOptions="flagNoExtractUi" />
</com.google.android.material.textfield.TextInputLayout>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment