Chromium Updater fix app unregister logic

App unregister logic had a gap in which apps were being
unregistered despite being on the machine. Also, changed
the method name to make it more accurate to what was
happening

Bug: 1056450
Change-Id: I6325c303c9a7693a13bcd44c8583b7ca4020c1fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439798
Commit-Queue: Michael Chang <donchan@microsoft.com>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812123}

chrome/updater/control_service_in_process.cc

@@ -33,7 +33,7 @@ ControlServiceInProcess::ControlServiceInProcess(
 void ControlServiceInProcess::Run(base::OnceClosure callback) {
   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
 
-  RemoveApps();
+  UnregisterMissingApps();
   MaybeCheckForUpdates(std::move(callback));
 }
 
@@ -79,14 +79,14 @@ void ControlServiceInProcess::MaybeCheckForUpdates(base::OnceClosure callback) {
           base::BindOnce(std::move(callback)), config_));
 }
 
-void ControlServiceInProcess::RemoveApps() {
+void ControlServiceInProcess::UnregisterMissingApps() {
   for (const auto& app_id : persisted_data_->GetAppIds()) {
     // Skip if app_id is equal to updater app id.
     if (app_id == kUpdaterAppId)
       continue;
 
     const base::FilePath ecp = persisted_data_->GetExistenceCheckerPath(app_id);
-    if (!ecp.empty() && base::PathExists(ecp)) {
+    if (!ecp.empty() && !base::PathExists(ecp)) {
       if (!persisted_data_->RemoveApp(app_id))
         VLOG(0) << "Could not remove registration of app " << app_id;
     }

chrome/updater/control_service_in_process.h

@@ -41,7 +41,7 @@ class ControlServiceInProcess : public ControlService {
 
   // Provides a way to remove apps from the persisted data if the app is no
   // longer installed on the machine.
-  void RemoveApps();
+  void UnregisterMissingApps();
 
   scoped_refptr<updater::Configurator> config_;
   scoped_refptr<updater::PersistedData> persisted_data_;