Commit 6ec8f2bb authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /content/renderer/media/stream.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=guidou@chromium.org

Bug: 925652
Change-Id: I01ea2b6aea86958b966cf75c5ae93abee02d928a
Reviewed-on: https://chromium-review.googlesource.com/c/1438392
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626393}
parent 1332e178
...@@ -2111,11 +2111,11 @@ TEST_P(MediaStreamConstraintsUtilAudioTest, UsedAndUnusedSources) { ...@@ -2111,11 +2111,11 @@ TEST_P(MediaStreamConstraintsUtilAudioTest, UsedAndUnusedSources) {
} }
} }
INSTANTIATE_TEST_CASE_P(, INSTANTIATE_TEST_SUITE_P(,
MediaStreamConstraintsUtilAudioTest, MediaStreamConstraintsUtilAudioTest,
testing::Values("", testing::Values("",
blink::kMediaStreamSourceTab, blink::kMediaStreamSourceTab,
blink::kMediaStreamSourceSystem, blink::kMediaStreamSourceSystem,
blink::kMediaStreamSourceDesktop)); blink::kMediaStreamSourceDesktop));
} // namespace content } // namespace content
...@@ -1463,9 +1463,9 @@ TEST_P(WebMediaPlayerMSTest, PictureInPictureTriggerCallback) { ...@@ -1463,9 +1463,9 @@ TEST_P(WebMediaPlayerMSTest, PictureInPictureTriggerCallback) {
EXPECT_CALL(*submitter_ptr_, StopUsingProvider()); EXPECT_CALL(*submitter_ptr_, StopUsingProvider());
} }
INSTANTIATE_TEST_CASE_P(, INSTANTIATE_TEST_SUITE_P(,
WebMediaPlayerMSTest, WebMediaPlayerMSTest,
::testing::Combine(::testing::Bool(), ::testing::Combine(::testing::Bool(),
::testing::Bool(), ::testing::Bool(),
::testing::Bool())); ::testing::Bool()));
} // namespace content } // namespace content
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment