Commit 6ee4b862 authored by Changhao Han's avatar Changhao Han Committed by Commit Bot

Fix node missing ownerDocument issue in getComputedStyleForNode

In rare cases, DevTools frontend will call getComputedStyleForNode
on a node that no longer has an owner document. This CL fixes this case,
other it will result in a DCHECK failure in document.cc.

Change-Id: I33b023e9ee600294cb8a3e9ea833b48e60bc0827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421668Reviewed-by: default avatarSimon Zünd <szuend@chromium.org>
Reviewed-by: default avatarAlex Rudenko <alexrudenko@chromium.org>
Reviewed-by: default avatarSigurd Schneider <sigurds@chromium.org>
Reviewed-by: default avatarPeter Marshall <petermarshall@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808852}
parent 39ffbeb9
...@@ -1192,6 +1192,8 @@ Response InspectorCSSAgent::getComputedStyleForNode( ...@@ -1192,6 +1192,8 @@ Response InspectorCSSAgent::getComputedStyleForNode(
response = dom_agent_->AssertNode(node_id, node); response = dom_agent_->AssertNode(node_id, node);
if (!response.IsSuccess()) if (!response.IsSuccess())
return response; return response;
if (!node->ownerDocument())
return Response::ServerError("Node does not have an owner document");
auto* computed_style_info = auto* computed_style_info =
MakeGarbageCollected<CSSComputedStyleDeclaration>(node, true); MakeGarbageCollected<CSSComputedStyleDeclaration>(node, true);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment