Commit 6efbd9fc authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

Enable -Wbitwise-conditional-parentheses

...except on Android, where this fires once in libunwind's
arm32 code, which we'll have to fix first.

Bug: 1016947
Change-Id: I5f64a1805736a30f1cf4050e9ec0ceb4ff4eae2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032791
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737741}
parent 749b942e
......@@ -1521,9 +1521,6 @@ config("default_warnings") {
# TODO(https://crbug.com/999886): Clean up, enable.
"-Wno-final-dtor-non-final-class",
# TODO(https://crbug.com/1016947) Clean up, enable.
"-Wno-bitwise-conditional-parentheses",
# TODO(https://crbug.com/1016945) Clean up, enable.
"-Wno-builtin-assume-aligned-alignment",
......@@ -1537,6 +1534,13 @@ config("default_warnings") {
"-Wno-range-loop-analysis",
]
if (is_android) {
cflags += [
# TODO(https://crbug.com/1016947) Clean up, enable.
"-Wno-bitwise-conditional-parentheses",
]
}
cflags_c += [
# TODO(https://crbug.com/995993): Clean up and enable.
"-Wno-implicit-fallthrough",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment