Commit 6f124066 authored by Esmael El-Moslimany's avatar Esmael El-Moslimany Committed by Commit Bot

Settings WebUI: add aria-expanded to advanced settings toggle button

Bug: 870460
Change-Id: I5a579b584f9fb13a0c1010109b3990ddd4306a0b
Reviewed-on: https://chromium-review.googlesource.com/c/1308601Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604732}
parent 63b98149
...@@ -220,9 +220,8 @@ ...@@ -220,9 +220,8 @@
inSearchMode, hasExpandedSection_)]]"> inSearchMode, hasExpandedSection_)]]">
<div id="toggleSpacer"></div> <div id="toggleSpacer"></div>
<h2 id="toggleContainer"> <h2 id="toggleContainer">
<paper-button id="advancedToggle" <paper-button id="advancedToggle" on-click="advancedToggleClicked_"
aria-active-attribute="aria-expanded" aria-expanded$="[[boolToString_(advancedToggleExpanded)]]">
on-click="advancedToggleClicked_">
<span>$i18n{advancedPageTitle}</span> <span>$i18n{advancedPageTitle}</span>
<iron-icon icon="[[getArrowIcon_(advancedToggleExpanded)]]"> <iron-icon icon="[[getArrowIcon_(advancedToggleExpanded)]]">
</iron-icon> </iron-icon>
......
...@@ -387,4 +387,13 @@ Polymer({ ...@@ -387,4 +387,13 @@ Polymer({
getArrowIcon_: function(opened) { getArrowIcon_: function(opened) {
return opened ? 'cr:arrow-drop-up' : 'cr:arrow-drop-down'; return opened ? 'cr:arrow-drop-up' : 'cr:arrow-drop-down';
}, },
/**
* @param {boolean} bool
* @return {string}
* @private
*/
boolToString_: function(bool) {
return bool.toString();
},
}); });
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment