Skip to content

GitLab

T
tangled
Commit 6f18ed2c authored by Takashi Toyoshima's avatar Takashi Toyoshima Committed by Commit Bot
Browse files
Options

WebFonts: adjust test timing to mitigate flakiness 

Current slow-loading.html requires at least 5 seconds to finish.
This may easily exceeds 6 seconds timeout of LayoutTests.

To stabilize the test, let me change the result check timing from
5 seconds to 4 seconds.

Bug: 818387
Change-Id: Id6b9b62c8bda3187850b71c57b3895ebca524bf2
Reviewed-on: https://chromium-review.googlesource.com/956828Reviewed-by: default avatarKunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542318}
parent a13b5276
Hide whitespace changes
Inline Side-by-side
Showing with 10 additions and 10 deletions
third_party/WebKit/LayoutTests/http/tests/webfont/slow-loading-expected.html
View file @ 6f18ed2c
......@@ -21,21 +21,21 @@
</head>
<body>
Ahem after 5 seconds:
Ahem after 4 seconds:
<br/>
<span class="testspan" id="span1">
abcdefg
</span>
<br/>
Arial after 5 seconds:
Arial after 4 seconds:
<br/>
<span class="testspan" id="span2">
abcdefg
</span>
<br/>
Blank after 5 seconds:
Blank after 4 seconds:
<br/>
<span class="testspan" id="span3">
abcdefg
......
third_party/WebKit/LayoutTests/http/tests/webfont/slow-loading.html
View file @ 6f18ed2c
......@@ -2,8 +2,8 @@
<head>
<style>
@font-face {
font-family:ahem-4sec;
src: url(slow-ahem-loading.cgi?delay=4000);
font-family:ahem-3sec;
src: url(slow-ahem-loading.cgi?delay=3000);
}
@font-face {
font-family:ahem-8sec;
......@@ -18,7 +18,7 @@
border: 1px solid;
}
#span1 {
font-family: ahem-4sec, Arial;
font-family: ahem-3sec, Arial;
}
#span2 {
font-family: ahem-8sec, Arial;
......@@ -30,21 +30,21 @@
</head>
<body>
Ahem after 5 seconds:
Ahem after 4 seconds:
<br/>
<span class="testspan" id="span1" style="display: none;">
abcdefg
</span>
<br/>
Arial after 5 seconds:
Arial after 4 seconds:
<br/>
<span class="testspan" id="span2" style="display: none;">
abcdefg
</span>
<br/>
Blank after 5 seconds:
Blank after 4 seconds:
<br/>
<span class="testspan" id="span3" style="display: none;">
abcdefg
......@@ -66,7 +66,7 @@ window.onload = function() {
displayElementAfter("span1", 0);
displayElementAfter("span2", 0);
displayElementAfter("span3", 3000);
setTimeout(function() { if (window.testRunner) testRunner.notifyDone(); }, 5000);
setTimeout(function() { if (window.testRunner) testRunner.notifyDone(); }, 4000);
};
</script>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment