Commit 6f29d60a authored by Michael Thiessen's avatar Michael Thiessen Committed by Commit Bot

Re-enable overscroll glow for VR.

Disabling overscroll glow in the way we did (in
https://codereview.chromium.org/2632493005) caused pull-to-refresh to
break. VR UX folks want overscroll glow anyways now, so let's just
turn it back on and un-break pull-to-refresh.

(Pull-to-refresh was broken because the overscroll controller wasn't
receiving Animate calls, so when the glow got 'shown' it never animated
away so the code thought it was always visible, and therefore prevented
pull-to-refresh)

Bug: 838679
Change-Id: I06fdbaadedfec702d43bf1915f3b05703da3d039
Reviewed-on: https://chromium-review.googlesource.com/1091658Reviewed-by: default avatarBo <boliu@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565450}
parent 82f18579
...@@ -1516,7 +1516,7 @@ void RenderWidgetHostViewAndroid::SendBeginFrame(viz::BeginFrameArgs args) { ...@@ -1516,7 +1516,7 @@ void RenderWidgetHostViewAndroid::SendBeginFrame(viz::BeginFrameArgs args) {
bool RenderWidgetHostViewAndroid::Animate(base::TimeTicks frame_time) { bool RenderWidgetHostViewAndroid::Animate(base::TimeTicks frame_time) {
bool needs_animate = false; bool needs_animate = false;
if (overscroll_controller_ && !is_in_vr_) { if (overscroll_controller_) {
needs_animate |= needs_animate |=
overscroll_controller_->Animate(frame_time, view_.parent()->GetLayer()); overscroll_controller_->Animate(frame_time, view_.parent()->GetLayer());
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment