Commit 6f312268 authored by Ehsan Karamad's avatar Ehsan Karamad Committed by Commit Bot

Cleanup a speculative fix for a crash

The fix did not work and the issue turned out to be something else. Cleaning up
most of the changes made in master@{#591833}.

Bug: 878359
Change-Id: I5432523622a82743d1c67e2768f70b437e580a22
Reviewed-on: https://chromium-review.googlesource.com/1236838Reviewed-by: default avatarJames MacLean <wjmaclean@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592909}
parent d2d014a7
......@@ -4,7 +4,6 @@
#include "extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container_base.h"
#include "base/debug/dump_without_crashing.h"
#include "base/guid.h"
#include "base/lazy_instance.h"
#include "base/memory/weak_ptr.h"
......@@ -317,18 +316,10 @@ void MimeHandlerViewContainerBase::CreateMimeHandlerViewGuestIfNecessary() {
// TODO(ekaramad): How can this happen? We should destroy the container if
// this happens at all. The process is however different for a plugin-based
// container.
base::debug::DumpWithoutCrashing();
return;
}
auto* guest_view = GetGuestView();
if (!guest_view) {
// TODO(ekaramad): How can this happen? Is it during startup or perhaps
// the interface request is rejected?
base::debug::DumpWithoutCrashing();
return;
}
// When the network service is enabled, subresource requests like plugins are
// made directly from the renderer to the network service. So we need to
// intercept the URLLoader and send it to the browser so that it can forward
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment