Commit 6f337097 authored by Phillis Tang's avatar Phillis Tang Committed by Chromium LUCI CQ

DPWA: show app name in install In-Product Help

Update desktop PWA install icon's In-Product Help to show the app's
name in display text.

Bug: 1149638
Change-Id: I1f2a7c201e2d2fda4533dcecb2a5f389b6d38f72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572744
Commit-Queue: Phillis Tang <phillis@chromium.org>
Reviewed-by: default avatarCollin Baker <collinbaker@chromium.org>
Reviewed-by: default avatarGreg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833960}
parent 84bdc972
...@@ -5967,7 +5967,7 @@ the Bookmarks menu."> ...@@ -5967,7 +5967,7 @@ the Bookmarks menu.">
Reopen a tab if you accidentally closed it Reopen a tab if you accidentally closed it
</message> </message>
<message name="IDS_DESKTOP_PWA_INSTALL_PROMO" desc="Text shown on promotional UI appearing next to the PWA install icon"> <message name="IDS_DESKTOP_PWA_INSTALL_PROMO" desc="Text shown on promotional UI appearing next to the PWA install icon">
To get back to here quickly, install this app To get back here quickly, install <ph name="APP_NAME">$1<ex>Google Maps</ex></ph>
</message> </message>
<message name="IDS_REOPEN_TAB_PROMO_SCREENREADER" desc="Text announced encouraging users to reopen a tab with the given shortcut"> <message name="IDS_REOPEN_TAB_PROMO_SCREENREADER" desc="Text announced encouraging users to reopen a tab with the given shortcut">
<ph name="SHORTCUT">$1<ex>CTRL+SHIFT+T</ex></ph> can reopen accidentally closed tabs <ph name="SHORTCUT">$1<ex>CTRL+SHIFT+T</ex></ph> can reopen accidentally closed tabs
......
a1ef35f0f98b4502ebb0a0f27eac40e063eb2c7f 34a9e96d0617141c5d1e542741566260cb823b75
\ No newline at end of file \ No newline at end of file
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
#include "chrome/browser/installable/installable_metrics.h" #include "chrome/browser/installable/installable_metrics.h"
#include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/user_education/feature_promo_controller.h" #include "chrome/browser/ui/user_education/feature_promo_controller.h"
#include "chrome/browser/ui/user_education/feature_promo_text_replacements.h"
#include "chrome/browser/ui/views/user_education/feature_promo_bubble_params.h" #include "chrome/browser/ui/views/user_education/feature_promo_bubble_params.h"
#include "chrome/browser/ui/views/user_education/feature_promo_controller_views.h" #include "chrome/browser/ui/views/user_education/feature_promo_controller_views.h"
#include "chrome/browser/ui/views/web_apps/pwa_confirmation_bubble_view.h" #include "chrome/browser/ui/views/web_apps/pwa_confirmation_bubble_view.h"
...@@ -93,8 +94,11 @@ void PwaInstallView::UpdateImpl() { ...@@ -93,8 +94,11 @@ void PwaInstallView::UpdateImpl() {
if (controller) { if (controller) {
// Reset the iph flag when it's shown again. // Reset the iph flag when it's shown again.
install_icon_clicked_after_iph_shown_ = false; install_icon_clicked_after_iph_shown_ = false;
controller->MaybeShowPromo( controller->MaybeShowPromoWithTextReplacements(
feature_engagement::kIPHDesktopPwaInstallFeature, feature_engagement::kIPHDesktopPwaInstallFeature,
FeaturePromoTextReplacements::WithString(
banners::AppBannerManager::GetInstallableWebAppName(
web_contents)),
base::Bind(&PwaInstallView::OnIphClosed, base::Bind(&PwaInstallView::OnIphClosed,
weak_ptr_factory_.GetWeakPtr())); weak_ptr_factory_.GetWeakPtr()));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment