Commit 6f993fda authored by Sigurdur Asgeirsson's avatar Sigurdur Asgeirsson Committed by Commit Bot

Remove DCHECKs on ack/ack request deserialization.

This allows fuzzing to deserialize arbitrary messages, while still
checking programming errors.

Bug: 1046895
Change-Id: Iafc5418ddbcbf8197ce3991d08c4f8d7bf374234
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031165
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: default avatarKen Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#737091}
parent 584d1745
...@@ -405,7 +405,6 @@ UserMessageReadAckRequestEvent::UserMessageReadAckRequestEvent( ...@@ -405,7 +405,6 @@ UserMessageReadAckRequestEvent::UserMessageReadAckRequestEvent(
uint64_t sequence_num_to_acknowledge) uint64_t sequence_num_to_acknowledge)
: Event(Type::kUserMessageReadAckRequest, port_name), : Event(Type::kUserMessageReadAckRequest, port_name),
sequence_num_to_acknowledge_(sequence_num_to_acknowledge) { sequence_num_to_acknowledge_(sequence_num_to_acknowledge) {
DCHECK(sequence_num_to_acknowledge);
} }
UserMessageReadAckRequestEvent::~UserMessageReadAckRequestEvent() = default; UserMessageReadAckRequestEvent::~UserMessageReadAckRequestEvent() = default;
...@@ -438,7 +437,6 @@ UserMessageReadAckEvent::UserMessageReadAckEvent( ...@@ -438,7 +437,6 @@ UserMessageReadAckEvent::UserMessageReadAckEvent(
uint64_t sequence_num_acknowledged) uint64_t sequence_num_acknowledged)
: Event(Type::kUserMessageReadAck, port_name), : Event(Type::kUserMessageReadAck, port_name),
sequence_num_acknowledged_(sequence_num_acknowledged) { sequence_num_acknowledged_(sequence_num_acknowledged) {
DCHECK(sequence_num_acknowledged);
} }
UserMessageReadAckEvent::~UserMessageReadAckEvent() = default; UserMessageReadAckEvent::~UserMessageReadAckEvent() = default;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment