Commit 6f9dd03c authored by bzanotti's avatar bzanotti Committed by Commit bot

[Signin iOS] Ensure SigninInteractionController displays signin errors.

SigninInteractionController uses an AlertCoordinator to display
potential sign-in errors, which requires the view controler to use to
present the alert dialog.
To ensure SigninInteractionController can always display correctly
errors, the AlertCoordinator must be given the top most visible view
controller (some errors are displayed before the sign-in screen is
shown, and some are displayed on top of the sign-in screen).

BUG=679809

Review-Url: https://codereview.chromium.org/2626003004
Cr-Commit-Position: refs/heads/master@{#443230}
parent efd3d8ba
...@@ -21,6 +21,7 @@ ...@@ -21,6 +21,7 @@
#import "ios/chrome/browser/ui/authentication/authentication_ui_util.h" #import "ios/chrome/browser/ui/authentication/authentication_ui_util.h"
#import "ios/chrome/browser/ui/authentication/chrome_signin_view_controller.h" #import "ios/chrome/browser/ui/authentication/chrome_signin_view_controller.h"
#import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h" #import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
#import "ios/chrome/browser/ui/util/top_view_controller.h"
#import "ios/public/provider/chrome/browser/chrome_browser_provider.h" #import "ios/public/provider/chrome/browser/chrome_browser_provider.h"
#import "ios/public/provider/chrome/browser/signin/chrome_identity.h" #import "ios/public/provider/chrome/browser/signin/chrome_identity.h"
#import "ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.h" #import "ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.h"
...@@ -200,7 +201,9 @@ using signin_ui::CompletionCallback; ...@@ -200,7 +201,9 @@ using signin_ui::CompletionCallback;
}; };
alertCoordinator_.reset([ios_internal::ErrorCoordinator( alertCoordinator_.reset([ios_internal::ErrorCoordinator(
error, dismissAction, viewController) retain]); error, dismissAction,
top_view_controller::TopPresentedViewControllerFrom(viewController))
retain]);
[alertCoordinator_ start]; [alertCoordinator_ start];
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment