Remove SettingsModernStatusBar kill switch

This switch was added in case of unexpected failures in stable. Since
it's now been running without any reported crashes since M78, remove it.

TBR=hnakashima@chromium.org

Fixed: 998990
Change-Id: I3bd5a55d7860d0a4a1374c33e5f0bd620019615b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013624
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733807}

chrome/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java

@@ -332,7 +332,6 @@ public abstract class ChromeFeatureList {
     public static final String SEND_TAB_TO_SELF = "SyncSendTabToSelf";
     public static final String SERVICE_MANAGER_FOR_DOWNLOAD = "ServiceManagerForDownload";
     public static final String SERVICE_WORKER_PAYMENT_APPS = "ServiceWorkerPaymentApps";
-    public static final String SETTINGS_MODERN_STATUS_BAR = "SettingsModernStatusBar";
     public static final String SHARED_CLIPBOARD_UI = "SharedClipboardUI";
     public static final String SHARING_QR_CODE_ANDROID = "SharingQrCodeAndroid";
     public static final String SHOPPING_ASSIST = "ShoppingAssist";

chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java

@@ -30,7 +30,6 @@ import androidx.annotation.VisibleForTesting;
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ChromeBaseAppCompatActivity;
-import org.chromium.chrome.browser.flags.ChromeFeatureList;
 import org.chromium.chrome.browser.help.HelpAndFeedback;
 import org.chromium.chrome.browser.init.ChromeBrowserInitializer;
 import org.chromium.chrome.browser.profiles.Profile;
@@ -296,10 +295,6 @@ public class SettingsActivity extends ChromeBaseAppCompatActivity
         // On P+, the status bar color is set via the XML theme.
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) return;
 
-        // Kill switch included due to past crashes when programmatically setting status bar color:
-        // https://crbug.com/880694.
-        if (!ChromeFeatureList.isEnabled(ChromeFeatureList.SETTINGS_MODERN_STATUS_BAR)) return;
-
         if (UiUtils.isSystemUiThemingDisabled()) return;
 
         // Dark status icons only supported on M+.

chrome/browser/android/chrome_feature_list.cc

@@ -183,7 +183,6 @@ const base::Feature* kFeaturesExposedToJava[] = {
     &kSearchEnginePromoNewDevice,
     &kServiceManagerForBackgroundPrefetch,
     &kServiceManagerForDownload,
-    &kSettingsModernStatusBar,
     &kSharedClipboardUI,
     &kSharingQrCodeAndroid,
     &kShoppingAssist,
@@ -545,9 +544,6 @@ const base::Feature kServiceManagerForBackgroundPrefetch{
 const base::Feature kServiceManagerForDownload{
     "ServiceManagerForDownload", base::FEATURE_DISABLED_BY_DEFAULT};
 
-const base::Feature kSettingsModernStatusBar{"SettingsModernStatusBar",
-                                             base::FEATURE_ENABLED_BY_DEFAULT};
-
 const base::Feature kShoppingAssist{"ShoppingAssist",
                                     base::FEATURE_DISABLED_BY_DEFAULT};
 

chrome/browser/android/chrome_feature_list.h

@@ -106,7 +106,6 @@ extern const base::Feature kSearchEnginePromoExistingDevice;
 extern const base::Feature kSearchEnginePromoNewDevice;
 extern const base::Feature kServiceManagerForBackgroundPrefetch;
 extern const base::Feature kServiceManagerForDownload;
-extern const base::Feature kSettingsModernStatusBar;
 extern const base::Feature kShoppingAssist;
 extern const base::Feature kSpannableInlineAutocomplete;
 extern const base::Feature kSpecialLocaleWrapper;