Commit 6fec9cfd authored by Jeevan Shikaram's avatar Jeevan Shikaram Committed by Commit Bot

[App Management] Re-enable test.

This CL re-enables test that were disabled due to build breakages.

Bug: 1003483
Change-Id: Ie20d5d788b5bea3615d0842148d5ebd7d0060e76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809136Reviewed-by: default avatarZentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699242}
parent eecc87f1
...@@ -8,20 +8,13 @@ suite('<app-management-pwa-permission-view>', function() { ...@@ -8,20 +8,13 @@ suite('<app-management-pwa-permission-view>', function() {
let pwaPermissionView; let pwaPermissionView;
let fakeHandler; let fakeHandler;
function getPermissionToggleByType(permissionType) {
return pwaPermissionView.root
.querySelector('[permission-type=' + permissionType + ']')
.root.querySelector('app-management-permission-toggle')
.root.querySelector('cr-toggle');
}
function getPermissionBoolByType(permissionType) { function getPermissionBoolByType(permissionType) {
return app_management.util.getPermissionValueBool( return app_management.util.getPermissionValueBool(
pwaPermissionView.app_, permissionType); pwaPermissionView.app_, permissionType);
} }
async function clickToggle(permissionType) { async function clickToggle(permissionType) {
getPermissionToggleByType(permissionType).click(); getPermissionToggleByType(pwaPermissionView, permissionType).click();
await fakeHandler.flushPipesForTesting(); await fakeHandler.flushPipesForTesting();
} }
...@@ -54,17 +47,20 @@ suite('<app-management-pwa-permission-view>', function() { ...@@ -54,17 +47,20 @@ suite('<app-management-pwa-permission-view>', function() {
test('toggle permissions', async function() { test('toggle permissions', async function() {
const checkToggle = async (permissionType) => { const checkToggle = async (permissionType) => {
assertTrue(getPermissionBoolByType(permissionType)); assertTrue(getPermissionBoolByType(permissionType));
assertTrue(getPermissionToggleByType(permissionType).checked); assertTrue(getPermissionCrToggleByType(pwaPermissionView, permissionType)
.checked);
// Toggle off. // Toggle off.
await clickToggle(permissionType); await clickToggle(permissionType);
assertFalse(getPermissionBoolByType(permissionType)); assertFalse(getPermissionBoolByType(permissionType));
assertFalse(getPermissionToggleByType(permissionType).checked); assertFalse(getPermissionCrToggleByType(pwaPermissionView, permissionType)
.checked);
// Toggle on. // Toggle on.
await clickToggle(permissionType); await clickToggle(permissionType);
assertTrue(getPermissionBoolByType(permissionType)); assertTrue(getPermissionBoolByType(permissionType));
assertTrue(getPermissionToggleByType(permissionType).checked); assertTrue(getPermissionCrToggleByType(pwaPermissionView, permissionType)
.checked);
}; };
await checkToggle('CONTENT_SETTINGS_TYPE_NOTIFICATIONS'); await checkToggle('CONTENT_SETTINGS_TYPE_NOTIFICATIONS');
......
...@@ -253,11 +253,9 @@ var OSSettingsAppManagementPwaPermissionViewTest = ...@@ -253,11 +253,9 @@ var OSSettingsAppManagementPwaPermissionViewTest =
} }
}; };
TEST_F( TEST_F('OSSettingsAppManagementPwaPermissionViewTest', 'AllJsTests', () => {
'OSSettingsAppManagementPwaPermissionViewTest', 'DISABLED_AllJsTests', mocha.run();
() => { });
mocha.run();
});
// Test fixture for the app management arc permission view element. // Test fixture for the app management arc permission view element.
// eslint-disable-next-line no-var // eslint-disable-next-line no-var
...@@ -276,11 +274,9 @@ var OSSettingsAppManagementArcPermissionViewTest = ...@@ -276,11 +274,9 @@ var OSSettingsAppManagementArcPermissionViewTest =
} }
}; };
TEST_F( TEST_F('OSSettingsAppManagementArcPermissionViewTest', 'AllJsTests', () => {
'OSSettingsAppManagementArcPermissionViewTest', 'DISABLED_AllJsTests', mocha.run();
() => { });
mocha.run();
});
// Test fixture for the app management managed app view. // Test fixture for the app management managed app view.
// eslint-disable-next-line no-var // eslint-disable-next-line no-var
...@@ -316,7 +312,7 @@ var OSSettingsAppManagementReducersTest = ...@@ -316,7 +312,7 @@ var OSSettingsAppManagementReducersTest =
} }
}; };
TEST_F('OSSettingsAppManagementReducersTest', 'DISABLED_AllJsTests', () => { TEST_F('OSSettingsAppManagementReducersTest', 'AllJsTests', () => {
mocha.run(); mocha.run();
}); });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment