Commit 702af1e5 authored by sczs's avatar sczs Committed by Commit Bot

[ios] Removes ReportAnIssue presentedViewController DCHECK

The DCHECK is triggered whenever Report an Issue is tapped and an
Infobar Message banner is currently being presented.

This DCHECK makes an assumption about another VC, and its misleading
since baseViewController might not even be the VC that ends up presenting
report an issue. Which means that this doesn't give us certainty that
the presenterVC is not presenting another VC.


This works as expected since BVC will dismiss the InfobarBanner and
then present report an issue.

Bug: 1016962
Change-Id: I516a6513422fe8817b291e00f0944d602b98357b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887754Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710800}
parent cd0f6a46
...@@ -203,7 +203,6 @@ enum class EnterTabSwitcherSnapshotResult { ...@@ -203,7 +203,6 @@ enum class EnterTabSwitcherSnapshotResult {
- (void)showReportAnIssueFromViewController: - (void)showReportAnIssueFromViewController:
(UIViewController*)baseViewController { (UIViewController*)baseViewController {
DCHECK(baseViewController); DCHECK(baseViewController);
DCHECK(![baseViewController presentedViewController]);
// This dispatch is necessary to give enough time for the tools menu to // This dispatch is necessary to give enough time for the tools menu to
// disappear before taking a screenshot. // disappear before taking a screenshot.
dispatch_async(dispatch_get_main_queue(), ^{ dispatch_async(dispatch_get_main_queue(), ^{
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment