Commit 703959c6 authored by benchan's avatar benchan Committed by Commit bot

Fix vector indexing bug in SerializationUtilsTest.WriteReadTest

This CL fixes a vector indexing bug in SerializationUtilsTest.WriteReadTest
where the code was supposed to ensure that each MetricSample entry in the
vector returned by SerializationUtils::ReadAndTruncateMetricsFromFile is not
null, instead of just the first entry.

BUG=None
TEST=component_unittests

Review-Url: https://codereview.chromium.org/2388853002
Cr-Commit-Position: refs/heads/master@{#422628}
parent e385b063
...@@ -154,8 +154,8 @@ TEST_F(SerializationUtilsTest, WriteReadTest) { ...@@ -154,8 +154,8 @@ TEST_F(SerializationUtilsTest, WriteReadTest) {
ScopedVector<MetricSample> vect; ScopedVector<MetricSample> vect;
SerializationUtils::ReadAndTruncateMetricsFromFile(filename, &vect); SerializationUtils::ReadAndTruncateMetricsFromFile(filename, &vect);
ASSERT_EQ(vect.size(), size_t(5)); ASSERT_EQ(vect.size(), size_t(5));
for (int i = 0; i < 5; i++) { for (MetricSample* sample : vect) {
ASSERT_TRUE(vect[0] != NULL); ASSERT_NE(nullptr, sample);
} }
EXPECT_TRUE(hist->IsEqual(*vect[0])); EXPECT_TRUE(hist->IsEqual(*vect[0]));
EXPECT_TRUE(crash->IsEqual(*vect[1])); EXPECT_TRUE(crash->IsEqual(*vect[1]));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment