Commit 704cdba1 authored by George Burgess IV's avatar George Burgess IV Committed by Commit Bot

fix instances of bugprone-argument-comment

This new clang-tidy check complains when param names /*in_comments=*/
don't match up with the actual parameter name they're being passed to.
Sometimes this is benign, other times, actual bugs are found.

Bug: 1136209
Change-Id: I3af15a8ff257a242396a8cc58ba8c0b1df74c934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459387Reviewed-by: default avatarAdam Langley <agl@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815677}
parent d910f829
......@@ -60,7 +60,7 @@ class OnRedirectReceived_Runnable : public Cronet_Runnable {
void Run() override {
Cronet_UrlRequestCallback_OnRedirectReceived(
callback_, /* request = */ nullptr, /* response_info = */ nullptr,
callback_, /* request = */ nullptr, /* info = */ nullptr,
new_location_url_.c_str());
}
......@@ -160,7 +160,7 @@ TEST_F(RunnablesTest, TestRunOnceClosureOnExecutor) {
// Invoke Cronet_UrlRequestCallback_OnResponseStarted using OnceClosure
Cronet_RunnablePtr runnable = new cronet::OnceClosureRunnable(
base::BindOnce(Cronet_UrlRequestCallback_OnResponseStarted, callback,
/* request = */ nullptr, /* response_info = */ nullptr));
/* request = */ nullptr, /* info = */ nullptr));
Cronet_UrlRequestCallback_SetClientContext(callback, this);
Cronet_Executor_Execute(executor, runnable);
base::RunLoop().RunUntilIdle();
......@@ -189,7 +189,7 @@ TEST_F(RunnablesTest, TestCronetBuffer) {
Cronet_RunnablePtr runnable = new cronet::OnceClosureRunnable(base::BindOnce(
RunnablesTest::UrlRequestCallback_OnReadCompleted, callback,
/* request = */ nullptr,
/* response_info = */ nullptr, buffer, /* bytes_read = */ 0));
/* info = */ nullptr, buffer, /* bytes_read = */ 0));
Cronet_UrlRequestCallback_SetClientContext(callback, this);
Cronet_Executor_Execute(executor, runnable);
base::RunLoop().RunUntilIdle();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment