Skip to content

GitLab

T
tangled
Commit 70519702 authored by Xinghui Lu's avatar Xinghui Lu Committed by Chromium LUCI CQ
Browse files
Options

Remove request malformed check in password_protection_request 

See https://crbug.com/1157814#c3 for the reasoning of this change.

Bug: 1157814
Change-Id: I33a81991fd108ddaf23f5d796941d1347f17ca9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589016Reviewed-by: default avatarVarun Khaneja <vakh@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836930}
parent 5a57aa3f
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 4 deletions
components/safe_browsing/content/password_protection/password_protection_request.cc
View file @ 70519702
...@@ -487,10 +487,8 @@ void PasswordProtectionRequest::SendRequest() { ...@@ -487,10 +487,8 @@ void PasswordProtectionRequest::SendRequest() {
WebUIInfoSingleton::GetInstance()->AddToPGPings(*request_proto_); WebUIInfoSingleton::GetInstance()->AddToPGPings(*request_proto_);
std::string serialized_request; std::string serialized_request;
if (!request_proto_->SerializeToString(&serialized_request)) { // TODO(crbug.com/1158582): Return early if request serialization fails.
Finish(RequestOutcome::REQUEST_MALFORMED, nullptr); request_proto_->SerializeToString(&serialized_request);
return;
}
net::NetworkTrafficAnnotationTag traffic_annotation = net::NetworkTrafficAnnotationTag traffic_annotation =
net::DefineNetworkTrafficAnnotation("password_protection_request", R"( net::DefineNetworkTrafficAnnotation("password_protection_request", R"(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment