Correct unscanned reason for services failures

Bug: 1135671
Change-Id: I5e1da7d0c5f8e45106c6ff40473bc9605049cdaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460761Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816581}

chrome/browser/safe_browsing/cloud_content_scanning/deep_scanning_utils.cc

@@ -83,10 +83,16 @@ void MaybeReportDeepScanningVerdict(
   for (const auto& result : response.results()) {
     if (result.status() !=
         enterprise_connectors::ContentAnalysisResponse::Result::SUCCESS) {
+      std::string unscanned_reason = "UNSCANNED_REASON_UNKNOWN";
+      if (result.tag() == "malware")
+        unscanned_reason = "MALWARE_SCAN_FAILED";
+      else if (result.tag() == "dlp")
+        unscanned_reason = "DLP_SCAN_FAILED";
+
       extensions::SafeBrowsingPrivateEventRouterFactory::GetForProfile(profile)
           ->OnUnscannedFileEvent(url, file_name, download_digest_sha256,
                                  mime_type, trigger, access_point,
-                                 "ANALYSIS_CONNECTOR_FAILED", content_size,
+                                 std::move(unscanned_reason), content_size,
                                  event_result);
     } else if (result.triggered_rules_size() > 0) {
       extensions::SafeBrowsingPrivateEventRouterFactory::GetForProfile(profile)

chrome/browser/safe_browsing/download_protection/deep_scanning_request_unittest.cc

@@ -669,7 +669,7 @@ TEST_F(DeepScanningReportingTest, ProcessesResponseCorrectly) {
     enterprise_connectors::ContentAnalysisResponse response;
 
     auto* malware_result = response.add_results();
-    malware_result->set_tag("malware");
+    malware_result->set_tag("dlp");
     malware_result->set_status(
         enterprise_connectors::ContentAnalysisResponse::Result::FAILURE);
 
@@ -685,7 +685,7 @@ TEST_F(DeepScanningReportingTest, ProcessesResponseCorrectly) {
         "76E00EB33811F5778A5EE557512C30D9341D4FEB07646BCE3E4DB13F9428573C",
         /*trigger*/
         extensions::SafeBrowsingPrivateEventRouter::kTriggerFileDownload,
-        /*reason*/ "ANALYSIS_CONNECTOR_FAILED",
+        /*reason*/ "DLP_SCAN_FAILED",
         /*mimetypes*/ ExeMimeTypes(),
         /*size*/ std::string("download contents").size(),
         /*result*/
@@ -722,7 +722,7 @@ TEST_F(DeepScanningReportingTest, ProcessesResponseCorrectly) {
         "76E00EB33811F5778A5EE557512C30D9341D4FEB07646BCE3E4DB13F9428573C",
         /*trigger*/
         extensions::SafeBrowsingPrivateEventRouter::kTriggerFileDownload,
-        /*reason*/ "ANALYSIS_CONNECTOR_FAILED",
+        /*reason*/ "MALWARE_SCAN_FAILED",
         /*mimetypes*/ ExeMimeTypes(),
         /*size*/ std::string("download contents").size(),
         /*result*/