Commit 7064d9c3 authored by Dominique Fauteux-Chapleau's avatar Dominique Fauteux-Chapleau Committed by Commit Bot

Correct unscanned reason for services failures

Bug: 1135671
Change-Id: I5e1da7d0c5f8e45106c6ff40473bc9605049cdaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460761Reviewed-by: default avatarDaniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816581}
parent c4b00134
...@@ -83,10 +83,16 @@ void MaybeReportDeepScanningVerdict( ...@@ -83,10 +83,16 @@ void MaybeReportDeepScanningVerdict(
for (const auto& result : response.results()) { for (const auto& result : response.results()) {
if (result.status() != if (result.status() !=
enterprise_connectors::ContentAnalysisResponse::Result::SUCCESS) { enterprise_connectors::ContentAnalysisResponse::Result::SUCCESS) {
std::string unscanned_reason = "UNSCANNED_REASON_UNKNOWN";
if (result.tag() == "malware")
unscanned_reason = "MALWARE_SCAN_FAILED";
else if (result.tag() == "dlp")
unscanned_reason = "DLP_SCAN_FAILED";
extensions::SafeBrowsingPrivateEventRouterFactory::GetForProfile(profile) extensions::SafeBrowsingPrivateEventRouterFactory::GetForProfile(profile)
->OnUnscannedFileEvent(url, file_name, download_digest_sha256, ->OnUnscannedFileEvent(url, file_name, download_digest_sha256,
mime_type, trigger, access_point, mime_type, trigger, access_point,
"ANALYSIS_CONNECTOR_FAILED", content_size, std::move(unscanned_reason), content_size,
event_result); event_result);
} else if (result.triggered_rules_size() > 0) { } else if (result.triggered_rules_size() > 0) {
extensions::SafeBrowsingPrivateEventRouterFactory::GetForProfile(profile) extensions::SafeBrowsingPrivateEventRouterFactory::GetForProfile(profile)
......
...@@ -669,7 +669,7 @@ TEST_F(DeepScanningReportingTest, ProcessesResponseCorrectly) { ...@@ -669,7 +669,7 @@ TEST_F(DeepScanningReportingTest, ProcessesResponseCorrectly) {
enterprise_connectors::ContentAnalysisResponse response; enterprise_connectors::ContentAnalysisResponse response;
auto* malware_result = response.add_results(); auto* malware_result = response.add_results();
malware_result->set_tag("malware"); malware_result->set_tag("dlp");
malware_result->set_status( malware_result->set_status(
enterprise_connectors::ContentAnalysisResponse::Result::FAILURE); enterprise_connectors::ContentAnalysisResponse::Result::FAILURE);
...@@ -685,7 +685,7 @@ TEST_F(DeepScanningReportingTest, ProcessesResponseCorrectly) { ...@@ -685,7 +685,7 @@ TEST_F(DeepScanningReportingTest, ProcessesResponseCorrectly) {
"76E00EB33811F5778A5EE557512C30D9341D4FEB07646BCE3E4DB13F9428573C", "76E00EB33811F5778A5EE557512C30D9341D4FEB07646BCE3E4DB13F9428573C",
/*trigger*/ /*trigger*/
extensions::SafeBrowsingPrivateEventRouter::kTriggerFileDownload, extensions::SafeBrowsingPrivateEventRouter::kTriggerFileDownload,
/*reason*/ "ANALYSIS_CONNECTOR_FAILED", /*reason*/ "DLP_SCAN_FAILED",
/*mimetypes*/ ExeMimeTypes(), /*mimetypes*/ ExeMimeTypes(),
/*size*/ std::string("download contents").size(), /*size*/ std::string("download contents").size(),
/*result*/ /*result*/
...@@ -722,7 +722,7 @@ TEST_F(DeepScanningReportingTest, ProcessesResponseCorrectly) { ...@@ -722,7 +722,7 @@ TEST_F(DeepScanningReportingTest, ProcessesResponseCorrectly) {
"76E00EB33811F5778A5EE557512C30D9341D4FEB07646BCE3E4DB13F9428573C", "76E00EB33811F5778A5EE557512C30D9341D4FEB07646BCE3E4DB13F9428573C",
/*trigger*/ /*trigger*/
extensions::SafeBrowsingPrivateEventRouter::kTriggerFileDownload, extensions::SafeBrowsingPrivateEventRouter::kTriggerFileDownload,
/*reason*/ "ANALYSIS_CONNECTOR_FAILED", /*reason*/ "MALWARE_SCAN_FAILED",
/*mimetypes*/ ExeMimeTypes(), /*mimetypes*/ ExeMimeTypes(),
/*size*/ std::string("download contents").size(), /*size*/ std::string("download contents").size(),
/*result*/ /*result*/
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment