Commit 7071ece8 authored by Shubham Aggarwal's avatar Shubham Aggarwal Committed by Commit Bot

Replace use of raw pointer by unqiue_ptr in top_sites_database.cc

Should have no behavioural effect.

Change-Id: Ibf58e36fc56307af001b66e9a874485f5c3a022f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548689
Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829535}
parent 0f88a8ef
......@@ -308,7 +308,7 @@ bool TopSitesDatabase::Init(const base::FilePath& db_name) {
bool TopSitesDatabase::InitImpl(const base::FilePath& db_name) {
const bool file_existed = base::PathExists(db_name);
db_.reset(CreateDB(db_name));
db_ = CreateDB(db_name);
if (!db_)
return false;
......@@ -563,7 +563,8 @@ bool TopSitesDatabase::RemoveURLNoTransaction(const MostVisitedURL& url) {
return delete_statement.Run();
}
sql::Database* TopSitesDatabase::CreateDB(const base::FilePath& db_name) {
std::unique_ptr<sql::Database> TopSitesDatabase::CreateDB(
const base::FilePath& db_name) {
// Settings copied from FaviconDatabase.
auto db = std::make_unique<sql::Database>(sql::DatabaseOptions{
.exclusive_locking = false, .page_size = 4096, .cache_size = 32});
......@@ -573,7 +574,7 @@ sql::Database* TopSitesDatabase::CreateDB(const base::FilePath& db_name) {
if (!db->Open(db_name))
return nullptr;
return db.release();
return db;
}
} // namespace history
......@@ -91,7 +91,7 @@ class TopSitesDatabase {
// invoke recovery code.
bool InitImpl(const base::FilePath& db_name);
sql::Database* CreateDB(const base::FilePath& db_name);
std::unique_ptr<sql::Database> CreateDB(const base::FilePath& db_name);
std::unique_ptr<sql::Database> db_;
sql::MetaTable meta_table_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment