Commit 7078f7b0 authored by Matt Falkenhagen's avatar Matt Falkenhagen Committed by Commit Bot

Fetch: Update comment about empty Response URL.

The comments talks of MakeGarbageCollected, but this was meant to
refer to `new Response()` in JavaScript.

Also quote the relevant specification step.

Change-Id: Ib9d545bd610b30d1ce04e6433355053165afd7b9
Reviewed-on: https://chromium-review.googlesource.com/c/1358108Reviewed-by: default avatarYutaka Hirano <yhirano@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613008}
parent e4dd1ebf
...@@ -556,15 +556,20 @@ void FetchManager::Loader::DidReceiveResponse( ...@@ -556,15 +556,20 @@ void FetchManager::Loader::DidReceiveResponse(
for (auto& it : response.HttpHeaderFields()) for (auto& it : response.HttpHeaderFields())
response_data->HeaderList()->Append(it.key, it.value); response_data->HeaderList()->Append(it.key, it.value);
// Corresponds to https://fetch.spec.whatwg.org/#main-fetch step:
// "If |internalResponse|’s URL list is empty, then set it to a clone of
// |request|’s URL list."
if (response.UrlListViaServiceWorker().IsEmpty()) { if (response.UrlListViaServiceWorker().IsEmpty()) {
// Note: |urlListViaServiceWorker| is empty, unless the response came from a // Note: |UrlListViaServiceWorker()| is empty, unless the response came from
// service worker, in which case it will only be empty if it was created // a service worker, in which case it will only be empty if it was created
// through MakeGarbageCollected<Response>(). // through new Response().
response_data->SetURLList(url_list_); response_data->SetURLList(url_list_);
} else { } else {
DCHECK(response.WasFetchedViaServiceWorker()); DCHECK(response.WasFetchedViaServiceWorker());
response_data->SetURLList(response.UrlListViaServiceWorker()); response_data->SetURLList(response.UrlListViaServiceWorker());
} }
response_data->SetMIMEType(response.MimeType()); response_data->SetMIMEType(response.MimeType());
response_data->SetResponseTime(response.ResponseTime()); response_data->SetResponseTime(response.ResponseTime());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment