Commit 708d74b1 authored by Yang Guo's avatar Yang Guo Committed by Commit Bot

Use path to new location of devtools frontend

Bug: 1011259
Change-Id: I97cb5b2956e2f847a534356ab66bc5b02cac27e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881552
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: default avatarMike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711166}
parent 0c2012b6
...@@ -158,7 +158,7 @@ See [Run Web Tests Directly with Content Shell](#Run-Web-Tests-Directly-with-Con ...@@ -158,7 +158,7 @@ See [Run Web Tests Directly with Content Shell](#Run-Web-Tests-Directly-with-Con
In most cases you don't need `--single-process` because `content_shell` is In most cases you don't need `--single-process` because `content_shell` is
in single process mode when running most web tests. in single process mode when running most web tests.
See [DevTools frontend](../../third_party/blink/renderer/devtools/readme.md#basics) See [DevTools frontend](../../third_party/devtools-frontend/src/README.md#basics)
for the commands that are useful for debugging devtools web tests. for the commands that are useful for debugging devtools web tests.
### In The Default Multiple Process Mode ### In The Default Multiple Process Mode
......
...@@ -7,14 +7,14 @@ def _CompileDevtoolsFrontend(input_api, output_api): ...@@ -7,14 +7,14 @@ def _CompileDevtoolsFrontend(input_api, output_api):
# Need to get all affected files from change (not just within this subtree) # Need to get all affected files from change (not just within this subtree)
local_paths = [f.AbsoluteLocalPath() for f in input_api.change.AffectedFiles()] local_paths = [f.AbsoluteLocalPath() for f in input_api.change.AffectedFiles()]
devtools = input_api.os_path.realpath( devtools = input_api.os_path.realpath(
input_api.os_path.join(input_api.PresubmitLocalPath(), '..', '..', 'devtools')) input_api.os_path.join(input_api.PresubmitLocalPath(), "..", "..", "..", "..", "devtools-frontend", "src"))
# If a devtools file is changed, the PRESUBMIT hook in Source/devtools # If a devtools file is changed, the PRESUBMIT hook in Source/devtools
# will run closure compiler # will run closure compiler
if (any("browser_protocol.pdl" in path for path in local_paths) and if (any("browser_protocol.pdl" in path for path in local_paths) and
all(devtools not in path for path in local_paths)): all(devtools not in path for path in local_paths)):
compile_path = input_api.os_path.join( compile_path = input_api.os_path.join(
input_api.PresubmitLocalPath(), "..", "..", "devtools", "scripts", "compile_frontend.py") input_api.PresubmitLocalPath(), "..", "..", "..", "..", "devtools-frontend", "src", "scripts", "test", "run_type_check.py")
out, _ = input_api.subprocess.Popen( out, _ = input_api.subprocess.Popen(
[input_api.python_executable, compile_path], stdout=input_api.subprocess.PIPE, [input_api.python_executable, compile_path], stdout=input_api.subprocess.PIPE,
stderr=input_api.subprocess.STDOUT).communicate() stderr=input_api.subprocess.STDOUT).communicate()
......
...@@ -3,9 +3,9 @@ ...@@ -3,9 +3,9 @@
# Use of this source code is governed by a BSD-style license that can be # Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file. # found in the LICENSE file.
"""Compile DevTools frontend code with Closure compiler. """Perform type check for devtools frontend
This script wraps devtools/scripts/compile_frontend.py. This script wraps devtools-frontend/src/scripts/test/run_type_check.py
DevTools bot kicks this script. DevTools bot kicks this script.
""" """
...@@ -13,8 +13,8 @@ import os ...@@ -13,8 +13,8 @@ import os
import sys import sys
sys.path.append(os.path.join( sys.path.append(os.path.join(
os.path.dirname(__file__), '..', '..', 'blink', 'renderer', 'devtools', 'scripts')) os.path.dirname(__file__), '..', '..', 'devtools-frontend', 'src', 'scripts', 'test'))
import compile_frontend import run_type_check
if __name__ == '__main__': if __name__ == '__main__':
sys.exit(compile_frontend.main()) sys.exit(run_type_check.main())
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment