Commit 70ab698b authored by Morten Stenshorne's avatar Morten Stenshorne Committed by Commit Bot

Invalidate background obscuration status in UpdateAfterLayout().

Remove InvalidateBackgroundObscurationStatus() from various
UpdateLayout() methods, and call it from UpdateAfterLayout() instead.
LayoutNG doesn't use UpdateLayout(), but it does still call
UpdateAfterLayout() when it has done its layout thing.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I3467d3c466e9c02885ffd7153d71f17e2c12da3a
Reviewed-on: https://chromium-review.googlesource.com/1166917Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581619}
parent 195815d7
......@@ -565,7 +565,6 @@ crbug.com/591099 paint/invalidation/resize-iframe-text.html [ Failure ]
crbug.com/591099 paint/invalidation/scroll/fixed-child-of-transformed-move-after-scroll.html [ Failure ]
crbug.com/591099 paint/invalidation/scroll/repaint-composited-child-in-scrolled-container.html [ Failure ]
crbug.com/591099 paint/invalidation/selection/selection-rl.html [ Failure ]
crbug.com/591099 paint/invalidation/stacking-context-lost.html [ Failure ]
crbug.com/591099 paint/invalidation/svg/animated-path-inside-transformed-html.xhtml [ Failure Pass ]
crbug.com/591099 paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html [ Failure ]
crbug.com/591099 paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html [ Failure ]
......
......@@ -446,7 +446,6 @@ void LayoutBlock::UpdateLayout() {
if (HasControlClip() && overflow_)
ClearLayoutOverflow();
InvalidateBackgroundObscurationStatus();
height_available_to_children_changed_ = false;
}
......
......@@ -509,7 +509,7 @@ void LayoutBox::UpdateLayout() {
DCHECK(!child->NeedsLayout());
child = child->NextSibling();
}
InvalidateBackgroundObscurationStatus();
UpdateAfterLayout();
ClearNeedsLayout();
}
......@@ -750,6 +750,8 @@ FloatRect LayoutBox::LocalBoundingBoxRectForAccessibility() const {
}
void LayoutBox::UpdateAfterLayout() {
InvalidateBackgroundObscurationStatus();
// Transform-origin depends on box size, so we need to update the layer
// transform after layout.
if (HasLayer()) {
......
......@@ -102,7 +102,6 @@ void LayoutReplaced::UpdateLayout() {
overflow_.reset();
AddVisualEffectOverflow();
UpdateAfterLayout();
InvalidateBackgroundObscurationStatus();
ClearNeedsLayout();
......
......@@ -233,7 +233,6 @@ void LayoutSVGRoot::UpdateLayout() {
has_box_decoration_background_ = IsDocumentElement()
? StyleRef().HasBoxDecorationBackground()
: HasBoxDecorationBackground();
InvalidateBackgroundObscurationStatus();
ClearNeedsLayout();
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment