Commit 70acbfa4 authored by tby's avatar tby Committed by Commit Bot

[Roselle] Fix app ID normalization bug.

I forgot to normalize the app IDs feeding into the Roselle model at
inference time, leading to some (not all) apps erroneously never being
ranked by the model.

Bug: 1019068
Change-Id: I0288c3cf591b92f9f0a9c356630b2212d29d16a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885852
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: default avatarCharles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710208}
parent a5c92450
......@@ -425,7 +425,7 @@ void SearchResultRanker::Rank(Mixer::SortedResults* results) {
}
} else {
if (app_ranker_) {
const auto& it = app_ranks_.find(result.result->id());
const auto& it = app_ranks_.find(NormalizeAppId(result.result->id()));
if (it != app_ranks_.end()) {
result.score = kBoostOfApps + ReRange(it->second, 0.67, 1.0);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment