Always generate a new unique_id for new MediaPlayer VideoFrames.
Downstream code has always assumed that when the unique_id for a VideoFrame doesn't change there's no work to be done. The fix is simply to use a wrapper frame which will have a unique id when a new frame is generated. It's surprising this ever worked, but the reason is that we have a boolean on VideoFrameCompositor which forces repaint of even non-unique frames. That can now be removed since we have multiple sites where unique frames are now required. BUG=1018904 TEST=repro steps from bug no longer repro. R=tguilbert Change-Id: I9e134bdf0f8b7b58d66c23b7e48658dd2be86a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888122 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#710500}
Showing
Please register or sign in to comment