Commit 70c9a5a0 authored by tfarina@chromium.org's avatar tfarina@chromium.org

Reland "components: Fix a couple of the TODO(GYP) todos."

It was originally committed at r286362 and reverted in r286467.

BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn
R=scottmg@chromium.org,brettw@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/427293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288006 0039d316-1c4b-4281-b951-d872f2087c98
parent e70af3ab
......@@ -48,6 +48,7 @@ static_library("browser") {
"//components/os_crypt",
"//components/resources",
"//components/strings",
"//components/user_prefs",
"//components/webdata/common",
"//content/public/browser",
"//content/public/common",
......@@ -62,7 +63,6 @@ static_library("browser") {
"//ui/gfx/geometry",
"//url",
#"../third_party/libjingle/libjingle.gyp:libjingle", TODO(GYP)
#"user_prefs", TODO(GYP)
]
forward_dependent_configs_from = [
......
......@@ -138,12 +138,14 @@ static_library("browser") {
"//components/autofill/core/common",
"//components/keyed_service/core",
"//components/os_crypt",
"//components/pref_registry",
"//components/resources",
"//components/strings",
"//components/webdata/common",
"//google_apis",
"//skia",
"//sql",
"//third_party/fips181",
"//third_party/icu",
"//third_party/libaddressinput:util",
"//third_party/libphonenumber",
......@@ -151,10 +153,8 @@ static_library("browser") {
"//ui/gfx",
"//ui/gfx/geometry",
"//url",
#'../third_party/fips181/fips181.gyp:fips181', TODO(GYP)
# TODO(GYP) also remove libjingle_stub_config below when this is added:
#'../third_party/libjingle/libjingle.gyp:libjingle', TODO(GYP)
#'pref_registry', TODO(GYP)
]
configs += [ "//content:libjingle_stub_config" ]
......
......@@ -81,12 +81,11 @@ static_library("invalidation") {
deps = [
"//base",
#"//components/gcm_driver", TODO(GYP)
"//google_apis",
"//components/gcm_driver",
"//components/keyed_service/core",
"//components/signin/core/browser:browser",
"//components/pref_registry",
#"//components/signin/core/browser", TODO(GYP)
"//components/signin/core/browser",
"//google_apis",
"//jingle:notifier",
"//sync",
"//third_party/cacheinvalidation",
......@@ -124,6 +123,7 @@ static_library("test_support") {
deps = [
"//base",
"//components/gcm_driver:test_support",
"//components/keyed_service/core",
"//google_apis",
"//jingle:notifier",
......@@ -132,6 +132,5 @@ static_library("test_support") {
"//sync",
"//testing/gmock",
"//third_party/cacheinvalidation",
#'gcm_driver_test_support', TODO(GYP)
]
}
......@@ -20,13 +20,13 @@ source_set("browser") {
"//base",
"//base:prefs",
"//base/third_party/dynamic_annotations",
"//components/bookmarks/browser",
"//components/keyed_service/core",
"//components/pref_registry",
"//components/strings",
"//components/url_matcher",
"//net",
"//ui/base",
#'bookmarks_browser', TODO(GYP)
]
if (enable_configuration_policy) {
......
......@@ -44,6 +44,7 @@ static_library("search_engines") {
deps = [
":prepopulated_engines",
"//base",
"//components/google/core/browser",
"//components/keyed_service/core",
"//components/metrics/proto",
"//components/pref_registry",
......@@ -58,7 +59,6 @@ static_library("search_engines") {
"//third_party/libxml",
"//ui/gfx",
"//url",
#'google_core_browser', TODO(GYP)
]
if (enable_configuration_policy) {
......
# Copyright 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
source_set("fips181") {
sources = [
"convert.cc",
"convert.h",
"fips181.cc",
"fips181.h",
"owntypes.h",
"randpass.cc",
"randpass.h",
"smbl.h",
]
deps = [
"//base",
]
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment