Commit 70dd3e99 authored by Gauthier Ambard's avatar Gauthier Ambard Committed by Commit Bot

[iOS] Disable web test

Those tests are flaky on the noncq bot. They are passing on all the
other bots. They are only failing for one very specific configuration
so disabling them for that configuration.

Fixed: 1059496
Change-Id: I77c8764cd02077abd1eb9871a7a968c8ca988830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093437
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749204}
parent 5ce2f677
...@@ -3,6 +3,7 @@ ...@@ -3,6 +3,7 @@
// found in the LICENSE file. // found in the LICENSE file.
#include "base/bind.h" #include "base/bind.h"
#include "base/ios/ios_util.h"
#import "base/test/ios/wait_util.h" #import "base/test/ios/wait_util.h"
#include "components/strings/grit/components_strings.h" #include "components/strings/grit/components_strings.h"
#import "ios/chrome/test/earl_grey/chrome_earl_grey.h" #import "ios/chrome/test/earl_grey/chrome_earl_grey.h"
...@@ -583,6 +584,13 @@ std::unique_ptr<net::test_server::HttpResponse> WindowLocationHashHandlers( ...@@ -583,6 +584,13 @@ std::unique_ptr<net::test_server::HttpResponse> WindowLocationHashHandlers(
// Tests that navigating forward from NTP works when resuming from session // Tests that navigating forward from NTP works when resuming from session
// restore. This is a regression test for https://crbug.com/814790. // restore. This is a regression test for https://crbug.com/814790.
- (void)testRestoreHistoryToNTPAndNavigateForward { - (void)testRestoreHistoryToNTPAndNavigateForward {
#if TARGET_IPHONE_SIMULATOR
if (!base::ios::IsRunningOnIOS13OrLater() && ![ChromeEarlGrey isIPadIdiom]) {
// This test is failing on one bot for that very specific configuration. See
// https://crbug.com/1059496 for more info.
EARL_GREY_TEST_DISABLED(@"Failing on iPhone 12 simulator.");
}
#endif
GREYAssertTrue(self.testServer->Start(), @"Test server failed to start."); GREYAssertTrue(self.testServer->Start(), @"Test server failed to start.");
const GURL destinationURL = self.testServer->GetURL(kSimpleFileBasedTestURL); const GURL destinationURL = self.testServer->GetURL(kSimpleFileBasedTestURL);
[ChromeEarlGrey loadURL:destinationURL]; [ChromeEarlGrey loadURL:destinationURL];
...@@ -603,6 +611,13 @@ std::unique_ptr<net::test_server::HttpResponse> WindowLocationHashHandlers( ...@@ -603,6 +611,13 @@ std::unique_ptr<net::test_server::HttpResponse> WindowLocationHashHandlers(
// Tests that restoring a placeholder URL is correctly restored. This is a // Tests that restoring a placeholder URL is correctly restored. This is a
// regression test from http://crbug.com/1011758. // regression test from http://crbug.com/1011758.
- (void)testRestoreHistoryToPlaceholderURL { - (void)testRestoreHistoryToPlaceholderURL {
#if TARGET_IPHONE_SIMULATOR
if (!base::ios::IsRunningOnIOS13OrLater() && ![ChromeEarlGrey isIPadIdiom]) {
// This test is failing on one bot for that very specific configuration. See
// https://crbug.com/1059496 for more info.
EARL_GREY_TEST_DISABLED(@"Failing on iPhone 12 simulator.");
}
#endif
GREYAssertTrue(self.testServer->Start(), @"Test server failed to start."); GREYAssertTrue(self.testServer->Start(), @"Test server failed to start.");
const GURL destinationURL("chrome://crash"); const GURL destinationURL("chrome://crash");
[ChromeEarlGrey loadURL:destinationURL]; [ChromeEarlGrey loadURL:destinationURL];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment