Commit 70e0d2d6 authored by spang's avatar spang Committed by Commit bot

ozone: evdev: Unsquelch some real errors in release

These are currently DLOG() but we really shouldn't be hiding them. Also
use PLOG() when we know errno will be set.

BUG=none
TEST=build

Review URL: https://codereview.chromium.org/1032233002

Cr-Commit-Position: refs/heads/master@{#322599}
parent f0e14409
......@@ -19,8 +19,7 @@ namespace {
bool GetEventBits(int fd, unsigned int type, void* buf, unsigned int size) {
if (ioctl(fd, EVIOCGBIT(type, size), buf) < 0) {
DLOG(ERROR) << "failed EVIOCGBIT(" << type << ", " << size << ") on fd "
<< fd;
PLOG(ERROR) << "EVIOCGBIT(" << type << ", " << size << ") on fd " << fd;
return false;
}
......@@ -29,7 +28,7 @@ bool GetEventBits(int fd, unsigned int type, void* buf, unsigned int size) {
bool GetPropBits(int fd, void* buf, unsigned int size) {
if (ioctl(fd, EVIOCGPROP(size), buf) < 0) {
DLOG(ERROR) << "failed EVIOCGPROP(" << size << ") on fd " << fd;
PLOG(ERROR) << "EVIOCGPROP(" << size << ") on fd " << fd;
return false;
}
......@@ -38,7 +37,7 @@ bool GetPropBits(int fd, void* buf, unsigned int size) {
bool GetAbsInfo(int fd, int code, struct input_absinfo* absinfo) {
if (ioctl(fd, EVIOCGABS(code), absinfo)) {
DLOG(ERROR) << "failed EVIOCGABS(" << code << ") on fd " << fd;
PLOG(ERROR) << "EVIOCGABS(" << code << ") on fd " << fd;
return false;
}
return true;
......@@ -55,7 +54,7 @@ bool GetSlotValues(int fd, int32_t* request, unsigned int size) {
size_t data_size = size * sizeof(*request);
if (ioctl(fd, EVIOCGMTSLOTS(data_size), request) < 0) {
DLOG(ERROR) << "failed EVIOCGMTSLOTS(" << request[0] << ") on fd " << fd;
PLOG(ERROR) << "EVIOCGMTSLOTS(" << request[0] << ") on fd " << fd;
return false;
}
......
......@@ -47,13 +47,13 @@ void GetTouchCalibration(TouchCalibration* cal) {
switches::kTouchCalibration),
",", &parts) >= 4) {
if (!base::StringToInt(parts[0], &cal->bezel_left))
DLOG(ERROR) << "Incorrect left border calibration value passed.";
LOG(ERROR) << "Incorrect left border calibration value passed.";
if (!base::StringToInt(parts[1], &cal->bezel_right))
DLOG(ERROR) << "Incorrect right border calibration value passed.";
LOG(ERROR) << "Incorrect right border calibration value passed.";
if (!base::StringToInt(parts[2], &cal->bezel_top))
DLOG(ERROR) << "Incorrect top border calibration value passed.";
LOG(ERROR) << "Incorrect top border calibration value passed.";
if (!base::StringToInt(parts[3], &cal->bezel_bottom))
DLOG(ERROR) << "Incorrect bottom border calibration value passed.";
LOG(ERROR) << "Incorrect bottom border calibration value passed.";
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment