Skip to content

GitLab

T
tangled
Commit 70e96287 authored by Dan Beam's avatar Dan Beam
Browse files
Options

WebUI Dark Mode: update "no downloads" illustration 

R=hcarmona@chromium.org
BUG=923224

Change-Id: I1fe33c412952be065cb8c5794030b1bdef8fd526
Reviewed-on: https://chromium-review.googlesource.com/c/1487842Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635855}
parent 892c5f8a
Hide whitespace changes
Inline Side-by-side
Showing with 19 additions and 21 deletions
chrome/browser/browser_resources.grd
View file @ 70e96287
...@@ -159,10 +159,9 @@ ...@@ -159,10 +159,9 @@
<include name="IDR_UKM_INTERNALS_JS" file="../../components/ukm/debug/ukm_internals.js" flattenhtml="true" compress="gzip" type="BINDATA" /> <include name="IDR_UKM_INTERNALS_JS" file="../../components/ukm/debug/ukm_internals.js" flattenhtml="true" compress="gzip" type="BINDATA" />
<include name="IDR_UKM_INTERNALS_CSS" file="../../components/ukm/debug/ukm_internals.css" flattenhtml="true" compress="gzip" type="BINDATA" /> <include name="IDR_UKM_INTERNALS_CSS" file="../../components/ukm/debug/ukm_internals.css" flattenhtml="true" compress="gzip" type="BINDATA" />
<if expr="not is_android"> <if expr="not is_android">
<include name="IDR_DOWNLOADS_1X_INCOGNITO_MARKER_PNG" file="resources\downloads\1x\incognito_marker.png" type="BINDATA" /> <include name="IDR_DOWNLOADS_IMAGES_1X_INCOGNITO_MARKER_PNG" file="resources\downloads\images\1x\incognito_marker.png" type="BINDATA" />
<include name="IDR_DOWNLOADS_2X_INCOGNITO_MARKER_PNG" file="resources\downloads\2x\incognito_marker.png" type="BINDATA" /> <include name="IDR_DOWNLOADS_IMAGES_2X_INCOGNITO_MARKER_PNG" file="resources\downloads\images\2x\incognito_marker.png" type="BINDATA" />
<include name="IDR_DOWNLOADS_1X_NO_DOWNLOADS_PNG" file="resources\downloads\1x\no_downloads.png" type="BINDATA" /> <include name="IDR_DOWNLOADS_IMAGES_NO_DOWNLOADS_SVG" file="resources\downloads\images\no_downloads.svg" type="BINDATA" />
<include name="IDR_DOWNLOADS_2X_NO_DOWNLOADS_PNG" file="resources\downloads\2x\no_downloads.png" type="BINDATA" />
<include name="IDR_DOWNLOADS_MOJO_LITE_JS" file="${root_gen_dir}\chrome\browser\ui\webui\downloads\downloads.mojom-lite.js" use_base_dir="false" type="BINDATA" /> <include name="IDR_DOWNLOADS_MOJO_LITE_JS" file="${root_gen_dir}\chrome\browser\ui\webui\downloads\downloads.mojom-lite.js" use_base_dir="false" type="BINDATA" />
<if expr="optimize_webui"> <if expr="optimize_webui">
<then> <then>
......
chrome/browser/resources/downloads/images/no_downloads.svg 0 → 100644
View file @ 70e96287
<svg width="237" height="289" xmlns="http://www.w3.org/2000/svg"><g fill="#9AA0A6" fill-rule="evenodd"><path d="M162.632 77.011c3.31-5.735 10.656-7.693 16.379-4.389l51.978 30.01c5.735 3.31 7.693 10.656 4.389 16.379l-30.01 51.978c-3.31 5.735-10.656 7.693-16.379 4.389l-51.978-30.01c-5.735-3.31-7.693-10.656-4.389-16.379l30.01-51.978zm3.723 44.885l3.08 17.998 24.669-10.06 4.186 34.748-56.58-32.667 24.645-10.02zM63.125 114.58L5.44 145.252c-4.532 2.41-6.269 8.09-3.859 12.623l30.672 57.686c2.41 4.532 8.09 6.269 12.623 3.859l57.686-30.672c4.532-2.41 6.269-8.09 3.859-12.623L75.748 118.44c-2.41-4.532-8.09-6.269-12.623-3.859zm-15.52 86.4c-2.623 1.395-5.91.39-7.304-2.233l-10.14-19.071c-6.993-13.152-1.988-29.523 11.163-36.516 13.152-6.992 29.523-1.987 36.516 11.164l10.14 19.072c1.395 2.622.39 5.909-2.233 7.303l-11.125 5.915-8.45-15.893 7.946-4.225-4.225-7.946c-4.669-8.781-15.563-12.112-24.343-7.443-8.781 4.669-12.112 15.563-7.443 24.343l4.225 7.947 7.947-4.225 8.45 15.893-11.125 5.915zM69.311.145c-4.671-.824-9.108 2.232-9.91 6.782L47.69 73.1c-.803 4.55 2.32 8.939 6.992 9.762l51.007 8.994c4.671.824 9.15-2.225 9.952-6.775l8.752-49.634-21.106-29.31L69.311.145zm24.704 34.819l4.168-23.636 19.468 27.803-23.636-4.167zM168.645 210.357l11.988 16.163-11.817 2.084-11.99-16.164-8.862 1.563 11.988 16.164-11.817 2.084-11.99-16.164-8.862 1.563 11.989 16.164-11.818 2.083-11.99-16.163-2.954.52c-5.14.907-8.147 5.378-7.3 10.427l8.856 50.225c.889 5.04 5.286 8.207 10.426 7.3l64.998-11.46c5.14-.907 8.189-5.386 7.3-10.427l-10.419-59.088-17.726 3.126z"/></g></svg>
\ No newline at end of file
chrome/browser/resources/downloads/item.html
View file @ 70e96287
...@@ -257,8 +257,8 @@ ...@@ -257,8 +257,8 @@
#incognito { #incognito {
bottom: 20px; bottom: 20px;
content: -webkit-image-set( content: -webkit-image-set(
url(chrome://downloads/1x/incognito_marker.png) 1x, url(chrome://downloads/images/1x/incognito_marker.png) 1x,
url(chrome://downloads/2x/incognito_marker.png) 2x); url(chrome://downloads/images/2x/incognito_marker.png) 2x);
position: absolute; position: absolute;
right: 16px; right: 16px;
} }
......
chrome/browser/resources/downloads/manager.html
View file @ 70e96287
...@@ -85,11 +85,10 @@ ...@@ -85,11 +85,10 @@
} }
#no-downloads .illustration { #no-downloads .illustration {
background: -webkit-image-set( background: url(chrome://downloads/images/no_downloads.svg) no-repeat
url(chrome://downloads/1x/no_downloads.png) 1x, center center;
url(chrome://downloads/2x/no_downloads.png) 2x) background-size: contain;
no-repeat center center; height: 144px;
height: 144px; /* Matches natural image height. */
margin-bottom: 32px; margin-bottom: 32px;
} }
......
chrome/browser/ui/webui/downloads/downloads_ui.cc
View file @ 70e96287
...@@ -102,21 +102,20 @@ content::WebUIDataSource* CreateDownloadsUIHTMLSource(Profile* profile) { ...@@ -102,21 +102,20 @@ content::WebUIDataSource* CreateDownloadsUIHTMLSource(Profile* profile) {
source->AddLocalizedString("inIncognito", IDS_DOWNLOAD_IN_INCOGNITO); source->AddLocalizedString("inIncognito", IDS_DOWNLOAD_IN_INCOGNITO);
source->AddResourcePath("1x/incognito_marker.png", source->AddResourcePath("images/1x/incognito_marker.png",
IDR_DOWNLOADS_1X_INCOGNITO_MARKER_PNG); IDR_DOWNLOADS_IMAGES_1X_INCOGNITO_MARKER_PNG);
source->AddResourcePath("2x/incognito_marker.png", source->AddResourcePath("images/2x/incognito_marker.png",
IDR_DOWNLOADS_2X_INCOGNITO_MARKER_PNG); IDR_DOWNLOADS_IMAGES_2X_INCOGNITO_MARKER_PNG);
source->AddResourcePath("1x/no_downloads.png", source->AddResourcePath("images/no_downloads.svg",
IDR_DOWNLOADS_1X_NO_DOWNLOADS_PNG); IDR_DOWNLOADS_IMAGES_NO_DOWNLOADS_SVG);
source->AddResourcePath("2x/no_downloads.png",
IDR_DOWNLOADS_2X_NO_DOWNLOADS_PNG);
source->AddResourcePath("downloads.mojom-lite.js", source->AddResourcePath("downloads.mojom-lite.js",
IDR_DOWNLOADS_MOJO_LITE_JS); IDR_DOWNLOADS_MOJO_LITE_JS);
#if BUILDFLAG(OPTIMIZE_WEBUI) #if BUILDFLAG(OPTIMIZE_WEBUI)
source->UseGzip(base::BindRepeating([](const std::string& path) { source->UseGzip(base::BindRepeating([](const std::string& path) {
return path != "1x/incognito_marker.png" && path != "1x/no_downloads.png" && return path != "images/1x/incognito_marker.png" &&
path != "2x/incognito_marker.png" && path != "2x/no_downloads.png" && path != "images/2x/incognito_marker.png" &&
path != "images/no_downloads.svg" &&
path != "downloads.mojom-lite.js"; path != "downloads.mojom-lite.js";
})); }));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment