Commit 711feaa6 authored by tapted@chromium.org's avatar tapted@chromium.org

Revert of Fix legacy dummy window visibility inheritance....

Revert of Fix legacy dummy window visibility inheritance. RenderWidgetHostViewAura may be shown(::Show()) bef… (https://codereview.chromium.org/272173002/)

Reason for revert:
Regression: makes frameless packaged app windows
unmovable in Aero. Confirmed with local git revert.

BUG=374681
TBR=ben@chromium.org

Original issue's description:
> Fix legacy dummy window visibility inheritance. RenderWidgetHostViewAura may be shown(::Show()) before legacy window creation, in such case dummy window was later created hidden which leads to wrong behaviour. E.g. NPAPI Flash in windowless mode tracks associated window visibility and slows down draw invalidation.
> 
> R=ben@chromium.org
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270739

Review URL: https://codereview.chromium.org/309553010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274172 0039d316-1c4b-4281-b951-d872f2087c98
parent 7948a423
...@@ -33,7 +33,6 @@ Anastasios Cassiotis <tom.cassiotis@gmail.com> ...@@ -33,7 +33,6 @@ Anastasios Cassiotis <tom.cassiotis@gmail.com>
Ancil George <ancilgeorge@samsung.com> Ancil George <ancilgeorge@samsung.com>
Andrei Parvu <andrei.prv@gmail.com> Andrei Parvu <andrei.prv@gmail.com>
Andrei Parvu <parvu@adobe.com> Andrei Parvu <parvu@adobe.com>
Andrei Kurushin <ajax16384@gmail.com>
Andrew Brampton <me@bramp.net> Andrew Brampton <me@bramp.net>
Andrew Tulloch <andrew@tullo.ch> Andrew Tulloch <andrew@tullo.ch>
Anish Patankar <anish.p@samsung.com> Anish Patankar <anish.p@samsung.com>
......
...@@ -988,17 +988,13 @@ void RenderWidgetHostViewAura::InternalSetBounds(const gfx::Rect& rect) { ...@@ -988,17 +988,13 @@ void RenderWidgetHostViewAura::InternalSetBounds(const gfx::Rect& rect) {
// Additonally the legacy dummy window is needed for accessibility and for // Additonally the legacy dummy window is needed for accessibility and for
// scrolling to work in legacy drivers for trackpoints/trackpads, etc. // scrolling to work in legacy drivers for trackpoints/trackpads, etc.
if (GetNativeViewId()) { if (GetNativeViewId()) {
bool show_legacy_window = false;
if (!legacy_render_widget_host_HWND_) { if (!legacy_render_widget_host_HWND_) {
legacy_render_widget_host_HWND_ = LegacyRenderWidgetHostHWND::Create( legacy_render_widget_host_HWND_ = LegacyRenderWidgetHostHWND::Create(
reinterpret_cast<HWND>(GetNativeViewId())); reinterpret_cast<HWND>(GetNativeViewId()));
show_legacy_window = window_->TargetVisibility();
} }
if (legacy_render_widget_host_HWND_) { if (legacy_render_widget_host_HWND_) {
legacy_render_widget_host_HWND_->SetBounds( legacy_render_widget_host_HWND_->SetBounds(
window_->GetBoundsInRootWindow()); window_->GetBoundsInRootWindow());
if (show_legacy_window)
legacy_render_widget_host_HWND_->Show();
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment