Commit 71543c0a authored by Trent Apted's avatar Trent Apted Committed by Commit Bot

Deflake GalleryBrowserTest.CheckAvailabilityOfEditAndPrintButtons.

Although it doesn't flake in Release, the presense of DCHECKs makes
this test fail. Waiting just for the gallery element could read the
button state in the static gallery.html DOM, so wait for the first image
to be fully loaded.

Bug: 857021
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I4e07384b105489410a73894b4a9e0a58bdae287d
Reviewed-on: https://chromium-review.googlesource.com/1125589Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572500}
parent 2e859f9f
...@@ -71,9 +71,8 @@ IN_PROC_BROWSER_TEST_F(GalleryBrowserTest, OpenMultipleImagesOnDrive) { ...@@ -71,9 +71,8 @@ IN_PROC_BROWSER_TEST_F(GalleryBrowserTest, OpenMultipleImagesOnDrive) {
StartTest(); StartTest();
} }
// Flaky in RELEASE crbug.com/857021
IN_PROC_BROWSER_TEST_F(GalleryBrowserTest, IN_PROC_BROWSER_TEST_F(GalleryBrowserTest,
DISABLED_CheckAvailabilityOfEditAndPrintButtons) { CheckAvailabilityOfEditAndPrintButtons) {
set_test_case_name("checkAvailabilityOfEditAndPrintButtons"); set_test_case_name("checkAvailabilityOfEditAndPrintButtons");
StartTest(); StartTest();
} }
......
...@@ -149,7 +149,9 @@ testcase.checkAvailabilityOfEditAndPrintButtons = function() { ...@@ -149,7 +149,9 @@ testcase.checkAvailabilityOfEditAndPrintButtons = function() {
return launchedPromise return launchedPromise
.then(function(result) { .then(function(result) {
appId = result.appId; appId = result.appId;
return gallery.waitForElement(appId, '.gallery[mode="slide"]'); // The buttons are disabled in the static gallery.html DOM, so wait for
// the image to be fully loaded before querying the button state.
return gallery.waitForSlideImage(appId, 640, 480, 'image3');
}) })
.then(function() { .then(function() {
return gallery.callRemoteTestUtil( return gallery.callRemoteTestUtil(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment